fix/formatter-mapped-type-break-mode - Branch - oxc-project/oxc

fix(formatter): only expand mapped types when newline immediately follows opening brace

#18087

Comparing

fix/formatter-mapped-type-break-mode

(

f69deb9

) with

fix/formatter-union-type-comments

(

d6bdb9d

)

Untouched: 38

Skipped: 7

Benchmarks

Skipped (7)

Passed

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

21 µs21 µs

formatter[errors.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

791 µs789.9 µs

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.9 ms1.9 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

122 µs121.9 µs

formatter[Search.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

1.9 ms1.9 ms

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

532.8 µs532.5 µs

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

358.3 µs358.1 µs

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.1 ms3.1 ms

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

3.1 ms3.1 ms

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

33.8 ms33.8 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms1.7 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.2 ms1.2 ms

formatter[core.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

2 ms2 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

885 µs885 µs

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.5 ms5.5 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

25.3 ms25.3 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

105.1 ms105.1 ms

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

437.1 µs437.1 µs

formatter[App.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

48.9 ms48.9 ms

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

2.2 ms2.2 ms

formatter[types.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

14.7 ms14.7 ms

formatter[index.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

4.6 ms4.6 ms

formatter[next.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

2.8 ms2.8 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

715.5 µs716.1 µs

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

80.7 µs80.7 µs

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

220.6 µs220.8 µs

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

56.7 ms56.8 ms

formatter[handle-comments.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

3.5 ms3.5 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

21.3 ms21.3 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.6 ms2.6 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

62.5 µs62.5 µs

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.3 ms1.3 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

4.1 ms4.1 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

135.3 µs135.8 µs

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

37.6 ms37.7 ms

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

-1%

8.6 µs8.7 µs

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

-2%

4.2 ms4.3 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

-2%

26.1 ms26.7 ms

Commits

Click on a commit to change the comparison range

Base

fix/formatter-union-type-comments

d6bdb9d

-0.18%

fix(formatter): only expand mapped types when newline immediately follows opening brace The previous logic expanded mapped types whenever there was any newline between `{` and the property name. But Prettier only expands when there's a newline immediately after `{`. For example: - `{ readonly\n [A in B]: T}` → single line (newline not immediately after `{`) - `{\n readonly [A in B]: T}` → multi-line (newline immediately after `{`) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

f69deb9

3 days ago

by Boshen

Home Terms Privacy Docs