feat/semantic-cfg-feature - Branch - oxc-project/oxc

perf(semantic): make CFG construction a compile-time feature

#13678Merged

Comparing

feat/semantic-cfg-feature

(

08c05df

) with

main

(

5084d16

)

Untouched: 37

No successful run was found on main ( 08c05df) during the generation of this report, so 5084d16 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Passed

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+3%

77.6 µs75.5 µs

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+2%

4.3 ms4.3 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+2%

28.2 ms27.8 ms

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

1.7 ms1.7 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

120.1 µs119.6 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.4 ms2.4 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.1 µs20 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

134.1 µs133.9 µs

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

357 µs356.7 µs

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.4 ms2.4 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

259.4 µs259.3 µs

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.3 ms1.3 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

870.3 µs870 µs

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

34.3 ms34.3 ms

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

22.6 ms22.6 ms

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

50.4 ms50.4 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.3 ms5.3 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

104.5 ms104.5 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

142.1 ms142.1 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.3 ms3.3 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

26.9 ms26.9 ms

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

733.4 µs733.5 µs

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

2.8 ms2.8 ms

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

206.9 ms206.9 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

56.4 ms56.4 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms1.7 ms

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

11.5 ms11.5 ms

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.9 ms1.9 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

713.4 µs713.8 µs

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.8 ms3.8 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

85 µs85.1 µs

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4 ms4 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

26.6 ms26.7 ms

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

11.5 µs11.6 µs

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

571.3 µs573.4 µs

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

-2%

31.1 ms31.7 ms

Commits

Click on a commit to change the comparison range

Base

main

5084d16

+0.14%

perf(semantic): make CFG construction a compile-time feature (#13678) part of #13646 ## Summary This PR converts the Control Flow Graph (CFG) functionality in `oxc_semantic` from runtime checks to a compile-time cargo feature, eliminating runtime overhead when CFG is not needed. ## Changes - Added `cfg` cargo feature to `oxc_semantic/Cargo.toml` with `oxc_cfg` as optional dependency - Feature-gated all CFG-related code using `#[cfg(feature = "cfg")]` - Updated `oxc_linter` to enable the `cfg` feature (since it requires CFG) - Made the `control_flow!` macro work correctly with and without the feature ## Benefits - **Performance**: Eliminates runtime `Option<CFG>` checks when feature is disabled - **Binary size**: Smaller binaries for crates that don't need CFG - **Cleaner API**: CFG methods only available when feature is enabled ## Test Plan - [x] All existing tests pass with `cargo test -p oxc_semantic --features cfg` - [x] `oxc_linter` builds and works correctly (it enables the feature) - [x] Feature is backward compatible - existing code continues to work 🤖 Generated with [Claude Code](https://claude.ai/code)

08c05df

2 months ago

by Boshen

Home Terms Privacy Docs