feat/ast-keyword-positions - Branch - oxc-project/oxc

feat(ast): add keyword and operator position fields to AST nodes

#18166

Comparing

feat/ast-keyword-positions

(

cc27d8a

) with

main

(

38e4b53

)

Untouched: 42

Skipped: 3

Benchmarks

Skipped (3)

Passed

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

26.4 ms26.1 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

721.4 µs718.5 µs

formatter[core.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

2 ms2 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

746.2 µs744.4 µs

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

13 µs12.9 µs

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.3 ms1.3 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

135.1 µs134.8 µs

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

19.8 ms19.7 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms1.7 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

63 µs62.9 µs

formatter[next.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

2.8 ms2.8 ms

formatter[Search.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

1.9 ms1.9 ms

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

702.1 µs701.3 µs

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

251.3 µs251 µs

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

37.8 ms37.7 ms

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4.3 ms4.3 ms

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

2.8 ms2.8 ms

formatter[types.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

14.8 ms14.8 ms

formatter[index.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

4.6 ms4.6 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

21.3 ms21.3 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

885 µs885 µs

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.5 ms5.5 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

492.5 ms492.6 ms

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

3.1 ms3.1 ms

formatter[App.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

49 ms49 ms

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

33.9 ms33.9 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

57 ms57 ms

formatter[handle-comments.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

3.5 ms3.5 ms

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

49.5 ms49.6 ms

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

358 µs358.3 µs

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

105.1 ms105.2 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

25.4 ms25.5 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.6 ms2.6 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

21.1 µs21.1 µs

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

81.1 µs81.2 µs

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

438.9 µs439.7 µs

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

4.2 ms4.2 ms

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.9 ms1.9 ms

formatter[errors.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

786.8 µs788.8 µs

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.2 ms1.2 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.1 ms3.1 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

-2%

120.4 µs122.3 µs

Commits

Click on a commit to change the comparison range

Base

main

38e4b53

-0.01%

feat(ast): add keyword and operator position fields to AST nodes Add `u32` position fields for keywords and punctuators where the position cannot be derived from `span.start`. This improves: - Linter fix accuracy - Formatter comment placement - Diagnostic accuracy in parser, semantic, and linter ## Changes ### Core Statements - `IfStatement`: `else_pos: Option<u32>` - `TryStatement`: `catch_pos: Option<u32>`, `finally_pos: Option<u32>` - `DoWhileStatement`: `while_pos: u32` - `ForInStatement`: `in_pos: u32` - `ForOfStatement`: `of_pos: u32` - `SwitchCase`: `keyword_pos: u32` ### Operators - `BinaryExpression`: `operator_pos: u32` - `LogicalExpression`: `operator_pos: u32` - `AssignmentExpression`: `operator_pos: u32` - `PrivateInExpression`: `in_pos: u32` ### Other Expressions - `ConditionalExpression`: `question_pos: u32`, `colon_pos: u32` - `ArrowFunctionExpression`: `arrow_pos: u32` ### TypeScript Nodes - `TSConditionalType`: `extends_pos: u32`, `question_pos: u32`, `colon_pos: u32` - `TSAsExpression`: `as_pos: u32` - `TSSatisfiesExpression`: `satisfies_pos: u32` - `TSMappedType`: `in_pos: u32` All position fields are marked with `#[content_eq(skip)]` and `#[estree(skip)]` to exclude them from content equality comparisons and ESTree output. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

cc27d8a

3 hours ago

by Boshen

Home Terms Privacy Docs