don/semantic/up/check-import-assignments - Branch - oxc-project/oxc

feat(semantic): check for invalid type import assignments

#4097Merged

Comparing

don/semantic/up/check-import-assignments

(

e386b62

) with

main

(

3fcad5e

)

Untouched: 29

Benchmarks

Passed

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

84.1 ms83.3 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

52.6 ms52.2 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

88.6 ms88.4 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

751.3 ms750.2 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

2.6 s2.6 s

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

1.6 ms1.6 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

75.7 µs75.6 µs

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

12.4 s12.4 s

codegen_sourcemap[cal.com.tsx]

tasks/benchmark/benches/codegen_sourcemap.rs::codegen_sourcemap::bench_codegen_sourcemap

35.5 ms35.5 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5 ms5 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

135.5 ms135.5 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

27.3 ms27.3 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

104.1 ms104.1 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.2 ms17.2 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

377.3 ms377.3 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

248.7 ms248.7 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.5 ms52.5 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

23.8 ms23.8 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.1 ms20.1 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

332.8 ms333 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

128.1 µs128.2 µs

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

207.1 µs207.3 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.4 µs22.4 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

250.1 µs250.5 µs

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

200.7 ms201.1 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

-1%

57.6 ms57.9 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

-2%

1.4 s1.4 s

Commits

Click on a commit to change the comparison range

Base

main

3fcad5e

-0.02%

feat(semantic): check for invalid type import assignments (#4097) Adds checks to `TSImportEqualsDeclaration` for invalid use of `import type` modifier. ```ts import { Foo } from './foo' namespace Bar { export class Baz {} } import type A = Foo.Baz; // not allowed import type B = Bar.Baz; // not allowed import type C = require('./c'); // allowed ```

e386b62

2 years ago

by DonIsaac

Home Terms Privacy Docs