don/semantic/fix/exports-in-ts-modules - Branch - oxc-project/oxc

fix(semantic): non-exported namespace member symbols flagged as exported

#4493Merged

Comparing

don/semantic/fix/exports-in-ts-modules

(

8f6f630

) with

main

(

4d10c6c

)

Untouched: 32

Benchmarks

Passed

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

47.1 ms46.6 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

+1%

3.2 ms3.2 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.3 s1.3 s

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

100.4 µs100.2 µs

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

233 µs232.6 µs

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

37.7 ms37.6 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

284.1 ms284 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

138.6 ms138.6 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

20.7 ms20.7 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

244.1 ms244 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

223.1 µs223.1 µs

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

75.7 ms75.7 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

379.6 ms379.6 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

516.5 ms516.5 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

18.3 ms18.3 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

103.7 ms103.7 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

32.1 ms32.1 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

62.4 ms62.4 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

75 ms75 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.1 ms20.1 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5 ms5 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.5 ms52.5 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

126 ms126 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

54.9 ms54.9 ms

prepass[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

17.6 ms17.6 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24 ms24 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.1 ms17.1 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

76.9 µs77 µs

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

775 ms775.6 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.7 µs22.7 µs

Commits

Click on a commit to change the comparison range

Base

main

4d10c6c

+0.08%

fix(semantic): non-exported namespace member symbols flagged as exported > Part of #4445 Fixes a bug where non-exported functions and variables inside of exported TS namespaces were being flagged with `SymbolFlags::Export` ```ts export namespace Foo { // incorrectly flagged as exported function foo() { } } ```

8f6f630

1 year ago

by DonIsaac

Home Terms Privacy Docs