don/10-24-fix_linter_react/iframe-missing-sandbox_ignores_vanilla_js_apis - Branch - oxc-project/oxc

fix(linter): `react/iframe-missing-sandbox` ignores vanilla JS APIs

#6872Merged

Comparing

don/10-24-fix_linter_react/iframe-missing-sandbox_ignores_vanilla_js_apis

(

f49b3e2

) with

main

(

c26020e

)

Untouched: 30

Benchmarks

Passed

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+2%

36 ms35.1 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24.2 µs24.1 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

157.1 µs156.7 µs

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

19.3 ms19.3 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

78.4 µs78.3 µs

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.5 s2.5 s

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.4 ms2.4 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

72.1 ms72.1 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

27.3 ms27.3 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

519.5 ms519.4 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

47.3 ms47.3 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

80.2 ms80.2 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.6 ms3.6 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.5 ms5.5 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

398.8 ms398.7 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

425.7 ms425.7 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

107.2 ms107.2 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24.7 ms24.7 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

53.6 ms53.6 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

13.3 ms13.3 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.5 ms17.5 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1 s1 s

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

7 ms7.1 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

18.7 ms18.7 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.4 ms22.4 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

117.3 ms117.3 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

62.8 ms62.8 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.8 ms2.8 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

97.1 µs97.4 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

-1%

30.4 ms30.8 ms

Commits

Click on a commit to change the comparison range

Base

main

c26020e

+0.05%

fix(linter): `react/iframe-missing-sandbox` ignores vanilla JS APIs (#6872) > Closes #6750 Fixes a false positive in `react/iframe-missing-sandbox` on `document.createElement`, which is not react and has no way of passing a sandbox prop/attribute on creation.

f49b3e2

1 year ago

by DonIsaac

Home Terms Privacy Docs