don/10-20-refactor_isolated-declarations_protect_internal_transform_methods - Branch - oxc-project/oxc

refactor(isolated-declarations): protect internal transform methods

#6723Merged

Comparing

don/10-20-refactor_isolated-declarations_protect_internal_transform_methods

(

2e2b748

) with

main

(

f05a273

)

Untouched: 30

Benchmarks

Passed

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+2%

36.1 ms35.5 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.5 s2.5 s

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

3.3 ms3.3 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

30.7 ms30.7 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

27.1 ms27.1 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

7 ms7 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

107.5 ms107.5 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

18.6 ms18.6 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

47.6 ms47.6 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

80 ms80 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.5 ms17.5 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.6 ms3.6 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

520.3 ms520.3 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

13.3 ms13.3 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24.7 ms24.7 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

53.5 ms53.5 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

426.4 ms426.4 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.9 ms2.9 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

118.9 ms118.9 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.4 ms22.4 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.4 s1.4 s

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.5 ms5.5 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

62.7 ms62.7 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

72.9 ms72.9 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

398.1 ms398.3 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

78.3 µs78.4 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

157.5 µs157.6 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

98.8 µs99 µs

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

19.7 ms19.7 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24.1 µs24.2 µs

Commits

Click on a commit to change the comparison range

Base

main

f05a273

+0.03%

refactor(isolated-declarations): protect internal transform methods (#6723) Change `pub fn` to `pub(crate) fn` for all internal methods in isolated declarations. I would appreciate someone who is more familiar with this code informing me if I incorrectly privatized methods that should be public.

2e2b748

1 year ago

by DonIsaac

Home Terms Privacy Docs