don/10-13-fix_linter/no-control-regex_allow_capture_group_references - Branch - oxc-project/oxc

fix(linter/no-control-regex): allow capture group references

#6529Merged

Comparing

don/10-13-fix_linter/no-control-regex_allow_capture_group_references

(

6d5a9f2

) with

main

(

2c32dac

)

Untouched: 29

Benchmarks

Passed

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+2%

31.2 ms30.7 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

+1%

62.9 ms62.5 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24.3 µs24.2 µs

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

49.4 ms49.2 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

80.3 µs80.2 µs

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

7.4 ms7.4 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

402.9 ms402.5 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

27.4 ms27.3 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

158.1 µs158 µs

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

19.6 ms19.6 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.5 ms5.5 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.8 ms2.8 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

519.3 ms519.3 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.4 ms22.4 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

13.3 ms13.3 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

25 ms25 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

426 ms426 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

54 ms54 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.7 ms17.7 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

80.2 ms80.2 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.6 ms3.6 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

108.7 ms108.7 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

118.9 ms118.9 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

72.8 ms72.9 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.3 s1.3 s

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

19.7 ms19.7 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

35.5 ms35.6 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.4 s2.4 s

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

99.8 µs100.2 µs

Commits

Click on a commit to change the comparison range

Base

main

2c32dac

+0.07%

fix(linter/no-control-regex): allow capture group references (#6529) Closes #6525. Allows `\1`, `\2`, etc. when referencing a capturing group. Examples of now-allowed patterns: ```js // both of these have a capture group with an index of 1 const r = /([a-z]+)\1/; const r = /\1([a-z]+)/; ``` Examples of still-banned patterns: ```js /([a-z])\0/; //out of range: capture groups are 1-indexed /([a-z])\2/; // there's only one capture group here ```

6d5a9f2

1 year ago

by DonIsaac

Home Terms Privacy Docs