don/10-08-test_linter_make_sure_all_auto-fixing_rules_have_fixer_test - Branch - oxc-project/oxc

test(linter): make sure all auto-fixing rules have fixer test

#6378Merged

Comparing

don/10-08-test_linter_make_sure_all_auto-fixing_rules_have_fixer_test

(

a6cae98

) with

main

(

f71c91e

)

Untouched: 29

Benchmarks

Passed

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+1%

1.3 s1.3 s

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24.3 µs24.3 µs

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.4 s2.4 s

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.5 ms2.5 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

72.8 ms72.7 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

72.9 ms72.9 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

157.3 µs157.2 µs

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

108.6 ms108.6 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

7.4 ms7.4 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

53.9 ms53.9 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.6 ms3.6 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

19.6 ms19.6 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

349.6 ms349.6 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

13.3 ms13.3 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

21 ms21 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

399.8 ms399.8 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

452.4 ms452.4 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.5 ms5.5 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

49.3 ms49.3 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

31.1 ms31.1 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

61.7 ms61.7 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.7 ms17.7 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

25 ms25 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.3 ms22.3 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

118.9 ms118.9 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

80 µs80.2 µs

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

19.7 ms19.8 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

36 ms36.4 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

98.7 µs99.8 µs

Commits

Click on a commit to change the comparison range

Base

main

f71c91e

-0.06%

test(linter): make sure all auto-fixing rules have fixer test (#6378) Testing will now fail If a rule advertises an auto-fix capability but no fixer test cases are added. This behavior may be bypassed using `intentionally_allow_no_fix_tests`. This should only be used in certain conditions, and we can check that it's not being abused in PR reviews. ```rs declare_oxc_lint!( /// Some docs SomeRule, correctness, fix ); #[test] fn test() { use crate::tester::Tester; let pass = vec![/* ... */]; let fail = vec![/* ... */]; // now fails, since `fix` is reported but no cases are passed to `.expect_fix()` Tester::new(SomeRule::NAME, pass, fail).test_and_snapshot(); }

a6cae98

1 year ago

by DonIsaac

Home Terms Privacy Docs