don/09-28-refactor_codegen_add_codebuffer_to_fix_soundness_hole - Branch - oxc-project/oxc

refactor(codegen): add `CodeBuffer` to fix soundness hole

#6148Merged

Comparing

don/09-28-refactor_codegen_add_codebuffer_to_fix_soundness_hole

(

204bf55

) with

main

(

8fe1b0a

)

Untouched: 29

Benchmarks

Passed

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+1%

1.4 s1.3 s

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+1%

2.5 s2.5 s

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24.2 µs24.1 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

158.7 µs158.4 µs

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

36.1 ms36 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

108.7 ms108.7 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

118.8 ms118.8 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.5 ms5.5 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.7 ms17.7 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

19.6 ms19.6 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

403.3 ms403.3 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

54 ms54 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

25 ms25 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

405.9 ms405.9 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

72.8 ms72.8 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

13.3 ms13.3 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

517.1 ms517.2 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

98.9 µs98.9 µs

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.6 ms3.6 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

49.3 ms49.3 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.4 ms22.4 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

31.1 ms31.1 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

62.9 ms62.9 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

7.4 ms7.4 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

27.3 ms27.3 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

80.2 ms80.3 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

80 µs80.1 µs

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

19.7 ms19.7 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

-1%

2.8 ms2.8 ms

Commits

Click on a commit to change the comparison range

Base

main

8fe1b0a

+0.03%

refactor(codegen): add `CodeBuffer` to fix soundness hole (#6148) # What This PR Does Adds `CodeBuffer`, a simple wrapper over a `Vec<u8>` with a protective and reduced API for upholding UTF-8 validity guarantees. Closes #6147. Note that this struct is actually quite small. Most of the added lines are doc comments.

204bf55

1 year ago

by DonIsaac

Home Terms Privacy Docs