don/09-23-feat_parser_use_bindingidentifier_for_namespace_declaration_names - Branch - oxc-project/oxc

feat(parser)!: use `BindingIdentifier` for `namespace` declaration names

#6003Merged

Comparing

don/09-23-feat_parser_use_bindingidentifier_for_namespace_declaration_names

(

01b878e

) with

main

(

87f700f

)

Untouched: 29

Benchmarks

Passed

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+1%

2.4 s2.4 s

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

19.7 ms19.6 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

100.2 µs99.7 µs

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.3 s1.3 s

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

118.9 ms118.8 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

61.7 ms61.7 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

399.9 ms399.8 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.3 ms22.3 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

31.1 ms31.1 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

19.6 ms19.6 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.6 ms3.6 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

13.3 ms13.3 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

451.8 ms451.8 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

21 ms21 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

349.2 ms349.2 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

79.9 µs79.9 µs

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

72.7 ms72.7 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

49.3 ms49.3 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

7.4 ms7.4 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.5 ms5.5 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

72.8 ms72.8 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

108.3 ms108.3 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

53.8 ms53.8 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

35.7 ms35.8 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

25 ms25 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.6 ms17.6 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

157.1 µs157.5 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

23.9 µs24 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

-1%

2.5 ms2.5 ms

Commits

Click on a commit to change the comparison range

Base

main

87f700f

+0.01%

feat(parser)!: use `BindingIdentifier` for `namespace` declaration names (#6003) Use `BindingIdentifier` instead of `IdentifierName` so that AST visitors can access the bound symbol id for the namespace's name. This makes namespace consistent with other named declarations, such as `Class`, `Function`, and `TSInterfaceDeclaration`. We should consider modifying `TSModuleDeclarationName::StringLiteral(...)` to also store a `symbol_id`, since one gets bound in semantic for it as well.

01b878e

1 year ago

by DonIsaac

Home Terms Privacy Docs