copilot/replace-type-parameter-fields - Branch - oxc-project/oxc

refactor(ast): Replace `TSMappedType::type_parameter` with `key` and `constraint` fields

#15121

Comparing

copilot/replace-type-parameter-fields

(

35cd6e6

) with

main

(

27b4f36

)

Untouched: 37

Benchmarks

Passed

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

72.2 µs71.3 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

26.6 ms26.3 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

135.7 µs135.1 µs

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4.3 ms4.3 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

4 ms4 ms

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

4.1 ms4.1 ms

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

33.8 ms33.8 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

26.5 ms26.4 ms

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

12.2 ms12.2 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.5 ms2.5 ms

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

213.1 ms213.1 ms

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

49.1 ms49.1 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

104.5 ms104.5 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.3 ms5.3 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

864.7 µs864.8 µs

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

355.3 µs355.3 µs

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

19.2 ms19.2 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.3 ms3.3 ms

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

24 ms24 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

476.1 ms476.2 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

56.9 ms57 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

710.9 µs711.2 µs

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.6 ms1.6 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

26.6 ms26.6 ms

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

774.1 µs774.5 µs

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.9 ms1.9 ms

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

2.9 ms2.9 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.3 ms1.3 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

705 µs705.7 µs

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms1.7 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

268.9 µs269.6 µs

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

581.2 µs583.1 µs

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

-1%

87 µs87.5 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

-1%

20.1 µs20.2 µs

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

-1%

13.3 µs13.4 µs

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

-1%

36 ms36.6 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

-2%

120.5 µs123.2 µs

Commits

Click on a commit to change the comparison range

Base

main

27b4f36

+0.04%

Format code

9bf2fa5

7 days ago

by Copilot

-0.15%

Add semantic binding for TSMappedType key field - Implement Binder trait for TSMappedType to bind the key field - Add TSMappedType case in builder.rs to call bind() - Key is bound with SymbolFlags::TypeParameter as suggested - All tests pass including test_ts_mapped_type - Snapshots updated showing keys are no longer unresolved references Co-authored-by: Dunqing <29533304+Dunqing@users.noreply.github.com>

35cd6e6

6 days ago

by Copilot

Home Terms Privacy Docs