copilot/preserve-comments-in-catch-clause - Branch - oxc-project/oxc

feat(codegen): preserve comments between CatchClause's param and body

#16167

Comparing

copilot/preserve-comments-in-catch-clause

(

4674fd9

) with

main

(

d4a1581

)

Untouched: 42

Skipped: 3

No successful run was found on main ( 78aa294) during the generation of this report, so d4a1581 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (3)

Passed

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

+2%

34.6 ms*33.9 ms

formatter[core.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

2.2 ms*2.2 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

135.6 µs*135.3 µs

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

18.8 ms18.7 ms

formatter[handle-comments.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

3.6 ms*3.6 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

26.3 ms*26.3 ms

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

460.6 µs*460.3 µs

formatter[next.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

2.8 ms*2.8 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

267.3 µs*267.2 µs

formatter[types.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

15.3 ms*15.3 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

465.2 ms465.2 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

21.2 µs*21.2 µs

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.3 ms*1.3 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

104.6 ms*104.6 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

4 ms*4 ms

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

46.8 ms46.8 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.4 ms*5.4 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.2 ms*3.2 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

26 ms*26 ms

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

356 µs*356.1 µs

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

763 µs*763.1 µs

formatter[errors.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

766.5 µs*766.7 µs

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4.3 ms*4.3 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

882.1 µs*882.3 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.5 ms*2.5 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

57 ms*57 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

720.2 µs*720.6 µs

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

4 ms*4 ms

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

2.9 ms*2.9 ms

formatter[index.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

4.6 ms*4.6 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

72.2 µs*72.3 µs

formatter[Search.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

1.9 ms*1.9 ms

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.6 ms*1.6 ms

formatter[App.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

50.1 ms*50.2 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

706.9 µs708 µs

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.9 ms*1.9 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

81.1 µs*81.2 µs

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

13.2 µs*13.2 µs

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms*1.7 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

-1%

26.3 ms*26.7 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

-2%

120.4 µs*122.6 µs

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

-2%

35.9 ms*36.7 ms

Commits

Click on a commit to change the comparison range

Base

main

d4a1581

+0.07%

revert(parser): remove RParen from trailing comment exclusion and add documentation Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>

bc81ea4

21 hours ago

by Copilot

-0.18%

fix(codegen): add minify check to catch clause comment space handling and add tests Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>

4674fd9

5 hours ago

by Copilot

Home Terms Privacy Docs