copilot/fix-commits-issue - Branch - oxc-project/oxc

fix(codegen): avoid invalid sourcemap tokens for positions beyond source bounds

#15069Merged

Comparing

copilot/fix-commits-issue

(

ff3ecaf

) with

main

(

3a1cdd0

)

Untouched: 37

Benchmarks

Passed

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

+2%

34.6 ms33.8 ms

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

13 µs12.9 µs

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

585 µs582.7 µs

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

35.8 ms35.7 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

263 µs262.5 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20 µs20 µs

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

12.2 ms12.2 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

4 ms4 ms

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

19.2 ms19.1 ms

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.6 ms1.6 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

26.4 ms26.4 ms

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

354.7 µs354.5 µs

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

863.7 µs863.3 µs

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.3 ms3.3 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

26.4 ms26.4 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.3 ms1.3 ms

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

748.2 µs748 µs

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

24 ms24 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.3 ms5.3 ms

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

49.1 ms49.1 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

477.3 ms477.3 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

104.5 ms104.5 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

26.7 ms26.7 ms

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

4.1 ms4.1 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

87.3 µs87.3 µs

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4.3 ms4.3 ms

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

213.4 ms213.4 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

56.4 ms56.4 ms

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

2.8 ms2.8 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms1.7 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

702.7 µs703.7 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.5 ms2.5 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

714.6 µs715.8 µs

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.9 ms1.9 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

134.4 µs134.8 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

71 µs71.5 µs

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

-2%

120.1 µs122.8 µs

Commits

Click on a commit to change the comparison range

Base

main

3a1cdd0

+0.05%

Move validation check to add_source_mapping_end Move position validation from add_source_mapping() to add_source_mapping_end() as suggested in code review. This is more precise since add_source_mapping_end() is specifically where span.end is used, which is the position that can be beyond source bounds when codegen adds punctuation. Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com> Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>

4b6e0de

6 days ago

by Copilot

-0.03%

Fix lint errors in sourcemap test - Collapse nested if statements with let-chaining - Use inline format args in assert messages - Replace redundant closure with method reference Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com> Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>

2a121f0

6 days ago

by Copilot

-0.02%

chore: tweak Signed-off-by: 翠 <green@sapphi.red>

ff3ecaf

6 days ago

by sapphi-red

Home Terms Privacy Docs