codegen-remove-const-generic - Branch - oxc-project/oxc

feat(codegen)!: remove const generic `MINIFY`

#5001Merged

Comparing

codegen-remove-const-generic

(

ce4d469

) with

main

(

b2ff2df

)

Untouched: 29

Benchmarks

Passed

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

+1%

3.7 ms3.7 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

73.1 ms72.9 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

228.9 µs228.4 µs

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

76.9 µs76.8 µs

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

46.6 ms46.6 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24.2 ms24.2 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

248 ms248 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

380.8 ms380.8 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

352.2 ms352.2 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

634.3 ms634.3 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.3 µs22.3 µs

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.5 ms52.5 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

104.3 ms104.3 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

4.9 ms4.9 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

19.9 ms19.9 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

125.5 ms125.5 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

140.5 ms140.5 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.1 ms17.1 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

75.4 ms75.4 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

38.5 ms38.5 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

63.6 ms63.6 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

61.6 ms61.7 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

20.7 ms20.7 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

795.3 ms797.1 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

-1%

1.4 s1.5 s

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

99.2 µs100 µs

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

-3%

20.3 ms20.9 ms

Commits

Click on a commit to change the comparison range

Base

main

b2ff2df

-0.11%

feat(codegen)!: remove const generic `MINIFY` (#5001) This is a premature optimization, makes the code complicated, and bloats the final binary size. The minify option is moved to `CodegenOptions`

ce4d469

1 year ago

by Boshen

Home Terms Privacy Docs