cblh:fix/4651 - Branch - oxc-project/oxc

oxc-project

oxc

Instrumentation

Wall Time

Blog Docs Changelog

fix(linter): improve prefer_namespace_keyword rule

#4751Merged

Comparing

cblh:fix/4651

(

d08058c

) with

main

(

c15c931

)

Untouched: 29

Benchmarks

Passed

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[checker.ts]

+1%

1.4 s1.4 s

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[cal.com.tsx]

+1%

783.1 ms777.2 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[react.development.js]

+1%

3.7 ms3.7 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[RadixUIAdoptionSection.jsx]

22.3 µs22.3 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[RadixUIAdoptionSection.jsx]

222.1 µs221.8 µs

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[pdf.mjs]

37.8 ms37.8 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[cal.com.tsx]

63 ms62.9 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[RadixUIAdoptionSection.jsx]

99.9 µs99.8 µs

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap::sourcemap[cal.com.tsx]

61.5 ms61.5 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[typescript.js]

635.6 ms635.6 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[cal.com.tsx]

24.2 ms24.2 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[antd.js]

352.6 ms352.6 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[RadixUIAdoptionSection.jsx]

77.3 µs77.3 µs

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[antd.js]

245.2 ms245.2 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen_sourcemap[checker.ts]

72.8 ms72.8 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[checker.ts]

12 ms12 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[checker.ts]

20 ms20 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations::isolated-declarations[vue-id.ts]

380.3 ms380.3 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[cal.com.tsx]

4.9 ms4.9 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[checker.ts]

52.4 ms52.4 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[antd.js]

19.9 ms19.9 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[antd.js]

104.3 ms104.3 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[pdf.mjs]

20.7 ms20.7 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[checker.ts]

76.1 ms76.1 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[pdf.mjs]

3.2 ms3.2 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[checker.ts]

139 ms139 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[antd.js]

126.9 ms126.9 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[pdf.mjs]

17.1 ms17.1 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[cal.com.tsx]

46.8 ms46.8 ms

Commits

Click on a commit to change the comparison range

Base

main

c15c931

+0.01%

fix(linter): improve prefer_namespace_keyword rule This commit enhances the `prefer_namespace_keyword` rule in the TypeScript linter: - Introduce helper functions `is_nest_module`, `is_valid_module`, and `is_invalid_module` to improve code readability and maintainability - Refactor the main `run` function to use these new helper functions - Add support for detecting and fixing nested module declarations (e.g., `module A.B {}`) - Update test cases to cover nested module scenarios - Improve error reporting for nested modules

2690691

1 year ago

by cblh

+0.11%

test(linter): correct nested module handling in prefer_namespace_keyword rule

32966bd

1 year ago

by cblh

-0.11%

chore(linter): Removed unnecessary context parameter from `is_valid_module` function.

914ffe1

1 year ago

by cblh

-0.09%

chore(linter): Refactor `prefer_namespace_keyword` rule in TypeScript linter - Simplified `is_nest_module` function by removing redundant line breaks.

264292a

1 year ago

by cblh

+0.05%

fix(linter): remove redundant diagnostic return in `prefer_namespace_keyword` rule - Removed an unnecessary return statement in the `prefer_namespace_keyword` rule to ensure proper execution flow and prevent premature diagnostic reporting.

6ae58c1

1 year ago

by cblh

+0.13%

Merge branch 'main' into fix/4651

d08058c

1 year ago

by rzvxa

Home Terms Privacy Docs