cblh:feature/20240704no-useless-undefined - Branch - oxc-project/oxc

feat(linter): implement unicorn/no-useless-undefined

#4079Merged

Comparing

cblh:feature/20240704no-useless-undefined

(

cd39baf

) with

main

(

ddfa343

)

Untouched: 31

Benchmarks

Passed

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

130.9 ms130.2 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

65.4 ms65.1 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

32.1 ms32 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

57.7 ms57.5 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

51.6 ms51.4 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

328.6 ms328.1 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5 ms5 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

144.8 ms144.8 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

104 ms104 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

27.7 ms27.7 ms

prepass[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

15.7 ms15.7 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.1 ms17.1 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24 ms24 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.4 ms52.4 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

252.3 ms252.3 ms

codegen_sourcemap[cal.com.tsx]

tasks/benchmark/benches/codegen_sourcemap.rs::codegen_sourcemap::bench_codegen_sourcemap

35.6 ms35.6 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

375.2 ms375.3 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

77 µs77.1 µs

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.1 ms20.1 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

1.6 ms1.7 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

195.9 ms196.1 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.6 µs22.6 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

128.2 µs128.4 µs

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

207 µs207.5 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

83.2 ms83.4 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

206.5 ms207.1 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

252.4 µs253.3 µs

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

-1%

1.4 s1.4 s

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

-1%

766.8 ms775.4 ms

Commits

Click on a commit to change the comparison range

Base

main

ddfa343

+0.01%

chore(linter): fix clippy error

3c1bead

1 year ago

by cblh

-0.04%

chore(linter): fix fmt error

6289f49

1 year ago

by cblh

-0.09%

Merge branch 'main' into feature/20240704no-useless-undefined

a619b20

1 year ago

by cblh

+0.12%

refactor(linter): optimize `no_useless_undefined` rule implementation - Updated `no_useless_undefined` rule to handle cases where `undefined` is used in parameter initializers, assignment expressions, and return statements in functions with explicit return types. - Added utility function `is_has_function_return_type` to check if a function has an explicit return type. - Added multiple new test cases to cover scenarios including: - Object properties and class fields with `undefined`. - Functions and methods returning `undefined`. - Various valid uses of `undefined` that should not trigger the rule. - Improved handling of nested functions returning `undefined`. - Improved existing test cases to ensure the rule correctly ignores cases where `undefined` is necessary. - Added TODO comments for potential future enhancements.

584d20f

1 year ago

by cblh

-0.06%

feat(linter): correct `no_useless_undefined` rule and adjust lint category - Changed the category of `NoUselessUndefined` rule from `pedantic` to `suspicious` for better classification. - Fixed `is_undefined` function to handle cases where the argument is not an expression. - Ensured `is_undefined` function correctly checks for undefined identifiers in arguments.

82fbdbc

1 year ago

by cblh

-0.04%

feat(linter): correct comment handling in `no_useless_undefined` rule

928f276

1 year ago

by cblh

+0.05%

feat(linter): update rule severity for no_useless_undefined

cd39baf

1 year ago

by cblh

Home Terms Privacy Docs