c/11-26-feat_linter_allow_lint_rules_with_the_same_name - Branch - oxc-project/oxc

oxc-project

oxc

Instrumentation

Wall Time

Blog Docs Changelog

feat(linter): allow lint rules with the same name

#7496Merged

Comparing

c/11-26-feat_linter_allow_lint_rules_with_the_same_name

(

bd0693b

) with

main

(

ef62b9d

)

Untouched: 30

Benchmarks

Passed

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[react.development.js]

+2%

1.4 ms1.4 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[cal.com.tsx]

+1%

36 ms35.6 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[pdf.mjs]

19.3 ms19.2 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[RadixUIAdoptionSection.jsx]

78.8 µs78.7 µs

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[checker.ts]

21.9 ms21.9 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[typescript.js]

241.8 ms241.8 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap::sourcemap[cal.com.tsx]

63.1 ms63.1 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[pdf.mjs]

3.6 ms3.6 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen_sourcemap[checker.ts]

77.5 ms77.5 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[checker.ts]

2.6 s2.6 s

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[pdf.mjs]

17.4 ms17.4 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[antd.js]

51.5 ms51.5 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[antd.js]

151 ms151 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[antd.js]

106.9 ms106.9 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[cal.com.tsx]

24.8 ms24.8 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[antd.js]

22.3 ms22.3 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations::isolated-declarations[vue-id.ts]

406.4 ms406.4 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[RadixUIAdoptionSection.jsx]

24.3 µs24.3 µs

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[checker.ts]

53.5 ms53.5 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[checker.ts]

13.3 ms13.3 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[cal.com.tsx]

5.5 ms5.5 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[antd.js]

116.8 ms116.8 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[checker.ts]

24.7 ms24.7 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[cal.com.tsx]

36.1 ms36.1 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[checker.ts]

72 ms72 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[RadixUIAdoptionSection.jsx]

2.5 ms2.5 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[cal.com.tsx]

1.1 s1.1 s

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[pdf.mjs]

9.2 ms9.2 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[RadixUIAdoptionSection.jsx]

155.7 µs156.1 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[RadixUIAdoptionSection.jsx]

-1%

97.3 µs98.4 µs

Commits

Click on a commit to change the comparison range

Base

main

ef62b9d

+0.05%

feat(linter): allow lint rules with the same name (#7496) Apologies @Boshen for the stupidly large diff. I've done the following: - `RuleEnum`'s members are now prefixed with the plugin name. e.g. `NoDebugger` has become `EslintNoDebugger` - updated tester.rs to accept the rule's NAME, CATEGORY to allow us to test rules with the same name (diff category) - updates `declare_all_lint_rules` satisfy the first above change.

bd0693b

10 months ago

by camc314

Home Terms Privacy Docs