c/08-31-refactor_oxlint_run_oxlint_before_tsgolint - Branch - oxc-project/oxc

oxc-project

oxc

Instrumentation

Wall Time

Blog Docs Changelog

refactor(oxlint): run oxlint before tsgolint

#13519Merged

Comparing

c/08-31-refactor_oxlint_run_oxlint_before_tsgolint

(

7ca0af4

) with

main

(

42e2c1d

)

Untouched: 37

Benchmarks

Passed

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[cal.com.tsx]

+1%

31.4 ms31 ms

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[RadixUIAdoptionSection.jsx]

+1%

579.5 µs575.9 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[cal.com.tsx]

26.4 ms26.3 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[react.development.js]

712.1 µs711.2 µs

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[binder.ts]

4 ms4 ms

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[binder.ts]

4.3 ms4.3 ms

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[binder.ts]

23.1 ms23.1 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[RadixUIAdoptionSection.jsx]

84.3 µs84.3 µs

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[react.development.js]

1.9 ms1.9 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[cal.com.tsx]

813.5 ms813.4 ms

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler::mangler[binder.ts]

733.6 µs733.5 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[react.development.js]

2.4 ms2.4 ms

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[cal.com.tsx]

34.4 ms34.4 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations::isolated-declarations[vue-id.ts]

56.4 ms56.4 ms

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[cal.com.tsx]

209.3 ms209.3 ms

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler::mangler[cal.com.tsx]

2.8 ms2.8 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[react.development.js]

1.3 ms1.3 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree::estree[checker.ts]

104.5 ms104.5 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[RadixUIAdoptionSection.jsx]

19.9 µs19.9 µs

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[binder.ts]

97.8 ms97.8 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[cal.com.tsx]

27.7 ms27.7 ms

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[react.development.js]

35.3 ms35.3 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[cal.com.tsx]

5.3 ms5.3 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[binder.ts]

3.3 ms3.3 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[cal.com.tsx]

26.8 ms26.8 ms

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[react.development.js]

11.7 ms11.7 ms

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[react.development.js]

356.8 µs356.9 µs

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[binder.ts]

870 µs870.3 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[RadixUIAdoptionSection.jsx]

134.2 µs134.3 µs

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler::mangler[react.development.js]

259.2 µs259.3 µs

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[binder.ts]

3.9 ms3.9 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[RadixUIAdoptionSection.jsx]

75.2 µs75.2 µs

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[react.development.js]

1.7 ms1.7 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[binder.ts]

1.7 ms1.7 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[RadixUIAdoptionSection.jsx]

1.7 ms1.7 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[RadixUIAdoptionSection.jsx]

119.6 µs119.8 µs

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler::mangler[RadixUIAdoptionSection.jsx]

11.5 µs11.5 µs

Commits

Click on a commit to change the comparison range

Base

main

42e2c1d

+0.03%

refactor(oxlint): run oxlint before tsgolint This refactors the linting process to run oxlint before tsgolint instead of the previous order. This change enables proper support for disable directives by allowing the disable directive data to be parsed and stored during the oxlint run, then utilized during the tsgolint run, and finally enables reporting of unused disable directives. - Moves the oxlint execution to run before tsgolint - Wraps the oxlint spawning in a block scope and clones necessary variables - Adds proper cleanup with drop(tx_error) when type-aware linting is disabled

7ca0af4

12 days ago

by camc314

Home Terms Privacy Docs