c/07-25-fix_linter_consistent-function-scoping_false_positive_with_hoisted_var_declarations - Branch - oxc-project/oxc

fix(linter): consistent-function-scoping false positive with hoisted var declarations

#12523Merged

Comparing

c/07-25-fix_linter_consistent-function-scoping_false_positive_with_hoisted_var_declarations

(

2b5bf98

) with

main

(

94b06ef

)

Untouched: 34

No successful run was found on main ( 2b5bf98) during the generation of this report, so 94b06ef was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

This report only contains results for the CPU Simulation instrument. To view results for the Wall Time instrument, click here.

Benchmarks

Passed

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

+1%

308.9 µs307.1 µs

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

4.9 ms4.8 ms

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

36.9 ms36.9 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

77.5 µs77.3 µs

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

57.5 ms57.4 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

714.8 µs714.4 µs

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

53.4 ms53.4 ms

minifier[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

80.2 µs80.2 µs

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4.2 ms4.2 ms

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

384.2 µs384.1 µs

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

930.1 µs929.9 µs

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.9 ms1.9 ms

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

162.3 ms162.3 ms

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.7 ms1.7 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.3 ms1.3 ms

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

146.4 ms146.4 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.3 ms3.3 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.8 ms5.8 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

104.7 ms104.7 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

28 ms28 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

4.3 ms4.3 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

26.8 ms26.8 ms

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

10.3 ms10.3 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.5 ms2.5 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.7 ms2.7 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

84.2 µs84.3 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

134 µs134.1 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

26.4 ms26.5 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.9 µs20.9 µs

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

20.7 ms20.7 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms1.7 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

127.5 µs128 µs

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

-2%

38.1 ms39 ms

Commits

Click on a commit to change the comparison range

Base

main

94b06ef

-0.07%

fix(linter): consistent-function-scoping false positive with hoisted var declarations (#12523) The rule was incorrectly starting from the scope containing the variable binding instead of the function's own scope. This caused false positives when var declarations were hoisted to a parent scope while the function captured variables from its lexical scope. Fixes the issue by using the function's own scope to determine parent scopes. fixes #12513

2b5bf98

4 months ago

by camc314

Home Terms Privacy Docs