Avatar for the oxc-project user
oxc-project
oxc
Instrumentation
Wall Time
BlogDocsChangelog

fix(linter)!: remove react from default plugin set

#11382Merged
Comparing
c/05-29-fix_linter_remove_react_from_default_plugin_set
(
ead5309
) with
main
(
8a34447
)
CodSpeed Performance Gauge
0%
Improvements
0
Regressions
0
Untouched
38
New
0
Dropped
0
Ignored
0

Benchmarks

Passed

formatter[binder.ts]
tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[binder.ts]
CodSpeed Performance Gauge
0%
18.8 ms
18.8 ms
formatter[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[RadixUIAdoptionSection.jsx]
CodSpeed Performance Gauge
0%
300.3 µs
299.6 µs
semantic[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[RadixUIAdoptionSection.jsx]
CodSpeed Performance Gauge
0%
72.5 µs
72.3 µs
mangler[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/minifier.rs::minifier::bench_mangler::mangler[RadixUIAdoptionSection.jsx]
CodSpeed Performance Gauge
0%
14.3 µs
14.3 µs
mangler[cal.com.tsx]
tasks/benchmark/benches/minifier.rs::minifier::bench_mangler::mangler[cal.com.tsx]
CodSpeed Performance Gauge
0%
3 ms
3 ms
parser[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[RadixUIAdoptionSection.jsx]
CodSpeed Performance Gauge
0%
89.4 µs
89.3 µs
formatter[react.development.js]
tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[react.development.js]
CodSpeed Performance Gauge
0%
9.2 ms
9.2 ms
formatter[cal.com.tsx]
tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[cal.com.tsx]
CodSpeed Performance Gauge
0%
142.8 ms
142.7 ms
transformer[react.development.js]
tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[react.development.js]
CodSpeed Performance Gauge
0%
637.7 µs
637.5 µs
parser[binder.ts]
tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[binder.ts]
CodSpeed Performance Gauge
0%
3.5 ms
3.5 ms
linter[cal.com.tsx]
tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[cal.com.tsx]
CodSpeed Performance Gauge
0%
1.3 s
1.3 s
isolated-declarations[vue-id.ts]
tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations::isolated-declarations[vue-id.ts]
CodSpeed Performance Gauge
0%
57.5 ms
57.5 ms
parser[react.development.js]
tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[react.development.js]
CodSpeed Performance Gauge
0%
1.4 ms
1.4 ms
minifier[binder.ts]
tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[binder.ts]
CodSpeed Performance Gauge
0%
3.5 ms
3.5 ms
linter[react.development.js]
tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[react.development.js]
CodSpeed Performance Gauge
0%
54.4 ms
54.4 ms
minifier[react.development.js]
tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[react.development.js]
CodSpeed Performance Gauge
0%
1.8 ms
1.8 ms
linter[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[RadixUIAdoptionSection.jsx]
CodSpeed Performance Gauge
0%
2.8 ms
2.8 ms
linter[binder.ts]
tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[binder.ts]
CodSpeed Performance Gauge
0%
148.5 ms
148.5 ms
lexer[react.development.js]
tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[react.development.js]
CodSpeed Performance Gauge
0%
383.6 µs
383.6 µs
estree[checker.ts]
tasks/benchmark/benches/parser.rs::parser::bench_estree::estree[checker.ts]
CodSpeed Performance Gauge
0%
103.4 ms
103.4 ms
lexer[cal.com.tsx]
tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[cal.com.tsx]
CodSpeed Performance Gauge
0%
5.8 ms
5.8 ms
mangler[binder.ts]
tasks/benchmark/benches/minifier.rs::minifier::bench_mangler::mangler[binder.ts]
CodSpeed Performance Gauge
0%
798.4 µs
798.4 µs
semantic[react.development.js]
tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[react.development.js]
CodSpeed Performance Gauge
0%
1.5 ms
1.5 ms
lexer[binder.ts]
tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[binder.ts]
CodSpeed Performance Gauge
0%
929.3 µs
929.4 µs
parser[cal.com.tsx]
tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[cal.com.tsx]
CodSpeed Performance Gauge
0%
28.8 ms
28.8 ms
codegen[react.development.js]
tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[react.development.js]
CodSpeed Performance Gauge
0%
2.2 ms
2.2 ms
semantic[cal.com.tsx]
tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[cal.com.tsx]
CodSpeed Performance Gauge
0%
25.4 ms
25.4 ms
semantic[binder.ts]
tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[binder.ts]
CodSpeed Performance Gauge
0%
3.9 ms
3.9 ms
codegen[cal.com.tsx]
tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[cal.com.tsx]
CodSpeed Performance Gauge
0%
38.9 ms
38.9 ms
codegen[binder.ts]
tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[binder.ts]
CodSpeed Performance Gauge
0%
4.8 ms
4.8 ms
transformer[cal.com.tsx]
tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[cal.com.tsx]
CodSpeed Performance Gauge
0%
24.6 ms
24.7 ms
lexer[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[RadixUIAdoptionSection.jsx]
CodSpeed Performance Gauge
0%
21 µs
21.1 µs
codegen[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[RadixUIAdoptionSection.jsx]
CodSpeed Performance Gauge
0%
131.9 µs
132.1 µs
transformer[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[RadixUIAdoptionSection.jsx]
CodSpeed Performance Gauge
0%
128.8 µs
129.2 µs
mangler[react.development.js]
tasks/benchmark/benches/minifier.rs::minifier::bench_mangler::mangler[react.development.js]
CodSpeed Performance Gauge
0%
282.8 µs
283.6 µs
minifier[RadixUIAdoptionSection.jsx]
tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[RadixUIAdoptionSection.jsx]
CodSpeed Performance Gauge
0%
65.5 µs
65.7 µs
transformer[binder.ts]
tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[binder.ts]
CodSpeed Performance Gauge
0%
1.5 ms
1.5 ms
minifier[cal.com.tsx]
tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[cal.com.tsx]
CodSpeed Performance Gauge
-3%
23.4 ms
24.1 ms

Commits

Click on a commit to change the comparison range
Base
main
8a34447
0%
fix(linter)!: remove react from default plugin set (#11382) This is a breaking change, but currently, how we check whether a react rule should run is opaque and unclear. For example, the `react/forward-ref-uses-ref` rule checks whether the framework flags `FrameworkFlags::React` is enabled, however this is never set to true meaning that this rule can never run. https://github.com/oxc-project/oxc/blob/bbb7eb1a27ac280febc3702bc5e7eb131dcc005a/crates/oxc_linter/src/rules/react/forward_ref_uses_ref.rs#L99-L101 This PR removes the react rule group from the default plugins, if users which to use the react plugin, they just have to add it to the plugins array. I have made thie change before 1.0, so hopefully the fact that it's breaking is ok.
ead5309
29 days ago
by camc314
© 2025 CodSpeed Technology
Home Terms Privacy Docs