12-17-feat_ast_add_astbuilder_atom_from_cow_ - Branch - oxc-project/oxc

feat(ast): add `AstBuilder::atom_from_cow`

#7974Merged

Comparing

12-17-feat_ast_add_astbuilder_atom_from_cow_

(

8b7c5ae

) with

main

(

c30a982

)

+3%

Improvements: 1

Untouched: 28

Benchmarks

Improved

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+3%

29 ms28.1 ms

Passed

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

146.9 µs146.3 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24.2 µs24.1 µs

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

74.4 ms74.4 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

34.8 ms34.8 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

50.6 ms50.6 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

9.3 ms9.3 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

21.6 ms21.6 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

71.3 ms71.2 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.1 s1.1 s

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

107.3 ms107.3 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.5 ms5.5 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.5 ms17.5 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

217.6 ms217.6 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.3 ms22.3 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

13.2 ms13.2 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

24.8 ms24.8 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

54 ms54.1 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.6 ms3.6 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

374.3 ms374.3 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

29.6 ms29.6 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.5 ms2.5 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

116.9 ms116.9 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

725.5 ms725.7 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.7 s2.7 s

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

19.2 ms19.3 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

87.6 µs87.7 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

74.7 µs75.3 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

-1%

2 ms2.1 ms

Commits

Click on a commit to change the comparison range

Base

main

c30a982

+3.21%

feat(ast): add `AstBuilder::atom_from_cow` (#7974) Various methods e.g. `PropertyKey::static_name` return a `Cow<'a, str>`. When we need to create an `Atom` from such a `Cow`, we can avoid reallocating the string into arena again if the `Cow` already borrows an arena string. The `Atom` can reference that same string, rather than making another copy of it in arena. Add `AstBuilder::atom_from_cow` method for this purpose.

8b7c5ae

1 year ago

by overlookmotel

Home Terms Privacy Docs