12-16-refactor_linter_yoda_simplify_code - Branch - oxc-project/oxc

refactor(linter/yoda): simplify code

#7941Merged

Comparing

12-16-refactor_linter_yoda_simplify_code

(

ff2a68f

) with

main

(

6f41d92

)

Untouched: 29

Benchmarks

Passed

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

+1%

2.1 ms2 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

19.3 ms19.2 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24.1 µs24 µs

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

87.7 µs87.6 µs

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

24.8 ms24.8 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.1 s1.1 s

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

9.3 ms9.3 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

35.1 ms35.1 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

71.2 ms71.2 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.6 ms3.6 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

374.4 ms374.3 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.5 ms17.5 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

54.1 ms54 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.5 ms5.5 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

217.6 ms217.6 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.3 ms22.3 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

107.3 ms107.3 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

13.2 ms13.2 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

725.7 ms725.7 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

21.6 ms21.6 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

29.6 ms29.6 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.5 ms2.5 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

51.2 ms51.2 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

116.8 ms116.9 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

74.4 ms74.4 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.7 s2.7 s

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

146.5 µs146.8 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

73.9 µs74.2 µs

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-3%

28.1 ms29 ms

Commits

Click on a commit to change the comparison range

Base

main

6f41d92

-0.06%

refactor(linter/yoda): simplify code (#7941) Follow-on after #7679. Simplify `do_diagnostic_with_fix`, in particular the search for the operator. Also reduce `span()` calls, as they have a cost.

ff2a68f

1 year ago

by overlookmotel

Home Terms Privacy Docs