12-16-fix_semantic_remove_inherting_scopeflags_modifier_from_parent_scope - Branch - oxc-project/oxc

fix(semantic): remove inherting `ScopeFlags::Modifiers` from parent scope

#7932Merged

Comparing

12-16-fix_semantic_remove_inherting_scopeflags_modifier_from_parent_scope

(

14c51ff

) with

main

(

850dd43

)

Untouched: 29

Benchmarks

Passed

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+2%

29 ms28.5 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

73.9 µs73.4 µs

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

19.3 ms19.2 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

87.4 µs87.2 µs

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

71.2 ms71.2 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

116.9 ms116.8 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

51.3 ms51.2 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

9.3 ms9.3 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

24.7 ms24.7 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

21.6 ms21.6 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.1 ms2.1 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.5 ms2.5 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.1 s1.1 s

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

376.4 ms376.4 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

217.6 ms217.6 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.5 ms5.5 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.5 ms17.5 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

725.4 ms725.4 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

53.9 ms53.9 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

13.2 ms13.2 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

107.1 ms107.1 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

76.2 ms76.3 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.6 ms3.6 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.3 ms22.3 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

35.1 ms35.2 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

29.5 ms29.6 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24.1 µs24.2 µs

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.7 s2.7 s

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

-1%

146.1 µs147.3 µs

Commits

Click on a commit to change the comparison range

Base

main

850dd43

+0.08%

fix(semantic): remove inherting `ScopeFlags::Modifier` from parent scope (#7932) close: #7900 After #4283 changed, we don't need to inherit `ScopeFlags` from the `constructor`, `set`, `get` anymore, I think this is a logic of forgetting to remove

14c51ff

1 year ago

by Dunqing

Home Terms Privacy Docs