12-11-feat_oxfmt_add_insert_final_newline_option - Branch - oxc-project/oxc

feat(oxfmt): add `insert_final_newline` option

#16757

Comparing

12-11-feat_oxfmt_add_insert_final_newline_option

(

e849aaf

) with

main

(

083e081

)

Untouched: 30

Skipped: 15

No successful run was found on main ( 2acd66e) during the generation of this report, so 083e081 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (15)

Passed

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

26.6 ms26.3 ms

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

+1%

13.2 µs13.1 µs

formatter[core.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

2.2 ms2.2 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

267.5 µs267.2 µs

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

81.4 µs81.4 µs

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

4 ms4 ms

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

358.1 µs357.8 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

135.6 µs135.5 µs

formatter[index.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

4.5 ms4.5 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.3 ms1.3 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.5 ms2.5 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

26.1 ms26.1 ms

formatter[types.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

14.7 ms14.7 ms

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

762.8 µs762.8 µs

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.5 ms5.5 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

104.5 ms104.5 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

21.1 µs21.1 µs

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

2.9 ms2.9 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

884.6 µs884.6 µs

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.2 ms3.2 ms

formatter[Search.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

1.9 ms1.9 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms1.7 ms

formatter[App.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

48.5 ms48.5 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

58 ms58 ms

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

442.8 µs443.3 µs

formatter[handle-comments.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

3.5 ms3.5 ms

formatter[next.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

2.7 ms2.7 ms

formatter[errors.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

768.5 µs769.4 µs

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

715.3 µs716.2 µs

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

-1%

35.9 ms36.2 ms

Commits

Click on a commit to change the comparison range

Base

main

083e081

+0.06%

feat(oxfmt): add `insert_final_newline` option closes #15066 The difficult part here is only calculate line ending at the really end, just before write, to avoid memory allocations on the source text when you insert a newline. @leaysgur This feature also requires a single file formatter so we can apply this to node API and file system write. The single file formatter need to accept a `Writer` so we can write to string or file.

e849aaf

2 days ago

by Boshen

Home Terms Privacy Docs