11-26-refactor_semantic_keep_consistent_symbolflags_for_function_id - Branch - oxc-project/oxc

refactor(semantic): always use `SymbolFlags::Function` for function id

#7479Merged

Comparing

11-26-refactor_semantic_keep_consistent_symbolflags_for_function_id

(

0fa58d7

) with

main

(

be62d38

)

Untouched: 33

Benchmarks

Passed

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

21.3 µs21.2 µs

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

26.1 ms26.1 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

17.1 ms17.1 ms

mangler[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

39.7 ms39.7 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

64.3 ms64.3 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

1.8 ms1.8 ms

mangler[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

16 ms16 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

65.7 ms65.7 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

92.3 µs92.3 µs

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

104.9 ms104.8 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

22.6 ms22.6 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24.8 ms24.8 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

96.1 ms96.1 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

290.8 ms290.8 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

56.6 ms56.6 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.9 ms5.9 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

14.8 ms14.8 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.7 ms2.7 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.9 ms3.9 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

18.3 ms18.3 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

3 s3 s

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

58.3 ms58.3 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

165.2 ms165.2 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

113.3 ms113.3 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

23.2 ms23.2 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

51.7 ms51.7 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

11.5 ms11.5 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

294.1 µs294.4 µs

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

30.1 ms30.1 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

74.4 µs74.5 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

-1%

143.6 µs144.7 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

-1%

34.1 ms34.4 ms

Commits

Click on a commit to change the comparison range

Base

main

be62d38

-0.06%

refactor(semantic): always use `SymbolFlags::Function` for function id (#7479) close #7402 related: #7470 The purpose of this PR is to keep the SymbolFlags of the function consistent. Always use `SymbolFlags::Function` for the function id symbol, to avoid adding extra logic to find accurate `SymbolFlags` for the function in `transformer`. This change adds a fallback redeclaration check for case `async function foo() {}; var foo;` in `SemanticBuilder::check_redeclaraion`. No performance difference here because redeclaration is always rare.

0fa58d7

9 months ago

by Dunqing

Home Terms Privacy Docs