10-16-fix_isolated_declarations_fix_memory_leak - Branch - oxc-project/oxc

fix(isolated_declarations): fix potential memory leak

#6622Merged

Comparing

10-16-fix_isolated_declarations_fix_memory_leak

(

2673397

) with

main

(

3af0840

)

Untouched: 30

Benchmarks

Passed

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+1%

1.3 s1.3 s

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

3.3 ms3.3 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

36.4 ms36.3 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

80 ms79.9 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

31.4 ms31.4 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

402.5 ms402.4 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.5 ms5.5 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.4 ms22.4 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

50.3 ms50.2 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.6 ms3.6 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

7.6 ms7.6 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

13.3 ms13.3 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

426.5 ms426.4 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

118.9 ms118.9 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

54 ms54 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

25 ms25 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

20.1 ms20.1 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.7 ms17.7 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

520.3 ms520.3 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

63 ms63 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

108.6 ms108.6 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

72.9 ms72.9 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

98.9 µs98.9 µs

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

27 ms27 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

19.7 ms19.7 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

80.3 µs80.4 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

157.5 µs157.8 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.8 ms2.8 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

-1%

24 µs24.1 µs

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

-1%

2.5 s2.5 s

Commits

Click on a commit to change the comparison range

Base

main

3af0840

-0.03%

fix(isolated_declarations): fix potential memory leak (#6622) `Scope` contains 2 x `FxHashMap`s, which own data outside of the arena. So this data will not be dropped when the allocator is dropped. The scope for this becoming a memory leak in practice is limited for 2 reasons: 1. All `Scope`s except the root one are popped from the stack by the end of traversal. That last scope's hashmaps are always empty, unless there are unresolved references (references to globals). 2. `oxc_allocator::Vec` is currently `Drop`. However, `oxc_allocator::Vec` will cease to be `Drop` in future, at which point this would become a real memory leak. Additionally, it doesn't make sense to store temporary data in the arena, as the arena is intended to hold data that needs to live as long as the AST, which temporary data doesn't.

2673397

1 year ago

by overlookmotel

Home Terms Privacy Docs