10-16-fix_formatter_improve_handling_of_dangling_comments_in_if_statements - Branch - oxc-project/oxc

fix(formatter): improve handling of dangling comments in if statements

#14658Merged

Comparing

10-16-fix_formatter_improve_handling_of_dangling_comments_in_if_statements

(

8c67314

) with

main

(

a9d50a7

)

-4%

Regressions: 1

Untouched: 32

Skipped: 4

No successful run was found on 10-16-fix_formatter_don_t_print_callexpression_as_memberchain_style_when_its_only_has_one_argument_and_it_is_a_templateliteral_on_its_own_line ( 6039089) during the generation of this report, so main ( a9d50a7) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (4)

Failed

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

Regression

-4%

35.5 ms36.9 ms

Passed

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

87.2 µs86.9 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

71.6 µs71.4 µs

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.9 ms1.9 ms

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

2.8 ms2.8 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

56.4 ms56.3 ms

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

4.1 ms4.1 ms

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.6 ms1.6 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

863.4 µs863.3 µs

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.3 ms1.3 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.3 ms5.3 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

26.6 ms26.6 ms

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

13.2 µs13.2 µs

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

104.5 ms104.5 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

26.4 ms26.4 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

26.4 ms26.4 ms

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

354.5 µs354.6 µs

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.3 ms3.3 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms1.7 ms

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

746.2 µs746.5 µs

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

715 µs715.5 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.5 ms2.5 ms

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

33.8 ms33.9 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

122.4 µs122.6 µs

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

12.1 ms12.1 ms

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4.3 ms4.3 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

19.9 µs19.9 µs

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

580.5 µs581.3 µs

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

262.9 µs263.3 µs

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

23.7 ms23.7 ms

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

210.9 ms211.3 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

4 ms4 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

133.7 µs134.1 µs

Commits

Click on a commit to change the comparison range

Base

main

a9d50a7

-3.91%

fix(formatter): improve handling of dangling comments in if statements

8c67314

1 month ago

by Dunqing

Home Terms Privacy Docs