10-14-refactor_linter_make_message.span_public - Branch - oxc-project/oxc

refactor(linter): make `Message.span` public

#14601Merged

Comparing

10-14-refactor_linter_make_message.span_public

(

3bfb8e1

) with

main

(

544c092

)

Untouched: 37

No successful run was found on main ( 3bfb8e1) during the generation of this report, so 544c092 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Passed

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

+2%

4.3 ms*4.2 ms

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.9 ms*1.9 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms*1.7 ms

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

23.7 ms*23.6 ms

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

13.2 µs*13.2 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.5 ms*2.5 ms

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

211.1 ms*211 ms

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.6 ms*1.6 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

120.6 µs*120.6 µs

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

26.6 ms*26.6 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.3 ms*1.3 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

104.5 ms*104.5 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.3 ms*3.3 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.3 ms*5.3 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

549 ms549.1 ms

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

2.8 ms*2.8 ms

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

59 ms59 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

56.3 ms*56.3 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

863.4 µs*863.6 µs

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

263.4 µs*263.4 µs

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

87 µs*87 µs

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

998.6 µs998.9 µs

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

33.8 ms*33.8 ms

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

354.6 µs*354.7 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

71.3 µs*71.3 µs

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

26.4 ms*26.4 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

715.3 µs*715.5 µs

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

22.2 ms22.2 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

4 ms*4 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

134 µs*134.1 µs

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

746.1 µs*746.9 µs

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

4.1 ms*4.1 ms

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

583.7 µs*584.9 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

19.9 µs*19.9 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

26.4 ms*26.5 ms

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

12.1 ms*12.2 ms

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

-1%

35.5 ms*36 ms

Commits

Click on a commit to change the comparison range

Base

main

544c092

refactor(linter): make `Message.span` public (#14601) just a bit of refactoring. The `GetSpan` trait is still available for: https://github.com/oxc-project/oxc/blob/e7c2748614453e7db707e53896e63f728bbc26b7/crates/oxc_linter/src/fixer/mod.rs#L374-L375

3bfb8e1

19 days ago

by Sysix

Home Terms Privacy Docs