10-14-perf_linter_numeric-separators-style_replace_regex_with_number_parser - Branch - oxc-project/oxc

perf(linter/numeric-separators-style): replace regex with number parser

#6546Merged

Comparing

10-14-perf_linter_numeric-separators-style_replace_regex_with_number_parser

(

77ddab8

) with

main

(

8d9a2da

)

Untouched: 30

Benchmarks

Passed

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+1%

3.3 ms3.3 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.3 s1.3 s

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

19.7 ms19.7 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

7.6 ms7.6 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

31.4 ms31.4 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

72.9 ms72.9 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

119 ms118.9 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

50.2 ms50.2 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

25 ms25 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

54.1 ms54.1 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

403.3 ms403.3 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

108.7 ms108.7 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.7 ms17.7 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

519.9 ms519.9 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

13.3 ms13.3 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

426.2 ms426.2 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

20.1 ms20.1 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.6 ms3.6 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.5 ms5.5 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.8 ms2.8 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

79.9 ms79.9 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

63 ms63 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.4 ms22.4 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

27 ms27 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

80.1 µs80.2 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

157.9 µs158.3 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24 µs24.1 µs

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.4 s2.5 s

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

98.5 µs99.1 µs

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-2%

35.7 ms36.3 ms

Commits

Click on a commit to change the comparison range

Base

main

8d9a2da

-0.07%

perf(linter/numeric-separators-style): replace regex with number parser (#6546) Building the Regex here is slow. We can take advantage of the fact that we know what the inputs should look like and parse the number directly. Cumulatively, this makes linting the RadixUIAdoptionSection.tsx ~7% faster: ``` hyperfine --warmup 100 --shell=none --runs 3000 './oxlint-main -W all --silent ./RadixUIAdoptionSection.jsx' './oxlint-num-separators -W all --silent ./RadixUIAdoptionSection.jsx' Benchmark 1: ./oxlint-main -W all --silent ./RadixUIAdoptionSection.jsx Benchmark 1: ./oxlint-main -W all --silent ./RadixUIAdoptionSection.jsx Time (mean ± σ): 4.1 ms ± 0.1 ms [User: 1.8 ms, System: 1.4 ms] Range (min … max): 3.8 ms … 4.7 ms 3000 runs Benchmark 2: ./oxlint-num-separators -W all --silent ./RadixUIAdoptionSection.jsx Time (mean ± σ): 3.8 ms ± 0.1 ms [User: 1.5 ms, System: 1.4 ms] Range (min … max): 3.5 ms … 4.5 ms 3000 runs Summary ./oxlint-num-separators -W all --silent ./RadixUIAdoptionSection.jsx ran 1.08 ± 0.05 times faster than ./oxlint-main -W all --silent ./RadixUIAdoptionSection.jsx ```

77ddab8

1 year ago

by camchenry

Home Terms Privacy Docs