10-13-fix_data_structures_fix_compilation_failure_on_older_rust_versions - Branch - oxc-project/oxc

fix(data_structures): fix compilation failure on older Rust versions

#6526Merged

Comparing

10-13-fix_data_structures_fix_compilation_failure_on_older_rust_versions

(

7cc05f1

) with

main

(

97c8a36

)

Untouched: 29

Benchmarks

Passed

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+2%

36.4 ms35.6 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24.2 µs24.1 µs

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

80.2 µs80.2 µs

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.4 s2.4 s

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

62.9 ms62.9 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

31.2 ms31.2 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

7.4 ms7.4 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

426 ms426 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

54 ms54 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

25 ms25 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

13.3 ms13.3 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.7 ms17.7 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

118.9 ms118.9 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

402.9 ms402.9 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.6 ms3.6 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

19.6 ms19.6 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

519.3 ms519.3 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

108.7 ms108.7 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.5 ms5.5 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

80.2 ms80.2 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.4 ms22.4 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.3 s1.3 s

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

72.8 ms72.8 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

49.4 ms49.4 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

27.3 ms27.4 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

19.7 ms19.7 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

98.7 µs98.9 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

158.9 µs159.3 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.8 ms2.8 ms

Commits

Click on a commit to change the comparison range

Base

main

97c8a36

+0.05%

fix(data_structures): fix compilation failure on older Rust versions (#6526) I thought I was being clever, but too clever = stupid. The dummy code designed to flag when our MSRV is bumped and supports `NonNull::add` would fail to compile on Rust versions below 1.80.0. Precisely because of the condition this code is testing - it's not supported! Fix this by skipping compilation unless running clippy.

7cc05f1

1 year ago

by overlookmotel

Home Terms Privacy Docs