10-06-refactor_traverse_function_to_get_var_name_from_node - Branch - oxc-project/oxc

refactor(traverse): function to get var name from node

#6317Merged

Comparing

10-06-refactor_traverse_function_to_get_var_name_from_node

(

c0e2fef

) with

main

(

fe25b65

)

Untouched: 29

Benchmarks

Passed

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

+1%

2.4 ms2.4 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

7.3 ms7.3 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

19.7 ms19.6 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

79.6 µs79.5 µs

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

72.8 ms72.8 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

48.8 ms48.8 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

107.3 ms107.3 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.4 ms5.4 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

53.3 ms53.3 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

118.9 ms118.8 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.5 ms17.5 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

13 ms13 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.5 ms3.5 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

20.9 ms20.9 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

347 ms347 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

449 ms449 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24.7 ms24.7 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

397.1 ms397.1 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

19.3 ms19.3 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

21.8 ms21.8 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

61.7 ms61.7 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

72.6 ms72.6 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.3 s1.3 s

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.4 s2.4 s

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

31 ms31.1 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

157.8 µs158.4 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

99 µs99.5 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

-1%

23.7 µs23.8 µs

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-2%

35.7 ms36.4 ms

Commits

Click on a commit to change the comparison range

Base

main

fe25b65

-0.09%

refactor(traverse): function to get var name from node (#6317) Pure refactor. Separate out the logic for creating a var name from an AST node into its own function, so it can be used standalone, outside of `generate_uid_based_on_node`. Apart from the new `get_var_name_from_node` function, and changing return type of `to_identifier` to `String`, the only other changes are moving files around.

c0e2fef

1 year ago

by overlookmotel

Home Terms Privacy Docs