10-06-refactor_transformer_exponentiation_transform_split_into_2_paths - Branch - oxc-project/oxc

refactor(transformer): exponentiation transform: split into 2 paths

#6316Merged

Comparing

10-06-refactor_transformer_exponentiation_transform_split_into_2_paths

(

7d93b25

) with

main

(

fe25b65

)

Untouched: 29

Benchmarks

Passed

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

+1%

2.4 ms2.4 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

157.8 µs157.7 µs

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

61.7 ms61.7 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

48.8 ms48.8 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

107.3 ms107.3 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

7.3 ms7.3 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

19.3 ms19.3 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

53.3 ms53.3 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.5 ms17.5 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

13 ms13 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

449 ms449 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

118.9 ms118.9 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.4 ms5.4 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

347 ms347 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

20.9 ms20.9 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24.7 ms24.7 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.5 ms3.5 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

397.1 ms397.1 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

21.8 ms21.8 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

72.8 ms72.8 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

72.6 ms72.6 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

19.7 ms19.7 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

79.6 µs79.6 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

31 ms31 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.4 s2.4 s

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.3 s1.3 s

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

35.7 ms35.9 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

99 µs99.4 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

-1%

23.7 µs23.8 µs

Commits

Click on a commit to change the comparison range

Base

main

fe25b65

-0.03%

refactor(transformer): exponentiation transform: split into 2 paths (#6316) Exponentiation transform has 2 paths for when left-hand side of `**=` is an identifier, and when it's a member expression. But these two paths are mixed up together in the `convert_assignment_expression`, `explode`, and `get_obj_ref` functions, with each branching on the same condition (is it an identifier or a member expression?). Refactor to separate out these 2 code paths, and make the logic easier to follow.

7d93b25

1 year ago

by overlookmotel

Home Terms Privacy Docs