10-06-fix_language_server_ignore_js_plugins - Branch - oxc-project/oxc

fix(language_server): ignore JS plugins

#14379Merged

Comparing

10-06-fix_language_server_ignore_js_plugins

(

6e8d2f6

) with

main

(

791c72a

)

Untouched: 4

Skipped: 33

No successful run was found on main ( 6e8d2f6) during the generation of this report, so 791c72a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (33)

Passed

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

33.1 ms33.1 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.6 ms1.6 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

731.4 ms731.4 ms

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

89 ms89 ms

Commits

Click on a commit to change the comparison range

Base

main

791c72a

+0.01%

fix(language_server): ignore JS plugins (#14379) Previously we produced an error when JS plugins are defined in config but no `ExternalLinter` is present. That's the desired behavior in `oxlint` CLI, because it happens when user is running Oxlint on an unsupported platform (32-bit, or big-endian). But it's *not* what we want to happen in language server. Language server does not yet support JS plugins, but user may want to use them in their project (via `oxlint` CLI), and language server should not fail with a "JS plugins are not supported" error on any file in such a project. This PR prevents that by adding an `is_enabled` field to `ExternalPluginStore`. By default, `is_enabled = true`, but language server sets it to `false`. When `false`, JS plugins are silently ignored, rather than producing an error. Note: A better solution would be to pass around `Option<ExternalPluginStore>` instead of `ExternalPluginStore` having an `is_enabled` flag. But JS plugin support will be added to the language server pretty soon, at which point we'll need to revert this change. `is_enabled` flag approach will produce less churn when we do that.

6e8d2f6

1 month ago

by overlookmotel

Home Terms Privacy Docs