10-02-feat_linter_add_vue_no-export-in-script-setup_rule - Branch - oxc-project/oxc

feat(linter): add `vue/no-export-in-script-setup` rule

#14307Merged

Comparing

10-02-feat_linter_add_vue_no-export-in-script-setup_rule

(

f5c6acc

) with

main

(

353b153

)

Untouched: 4

Skipped: 33

No successful run was found on main ( f5c6acc) during the generation of this report, so 353b153 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (33)

Passed

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

33.1 ms33.1 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

731.3 ms731.3 ms

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

89 ms89 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.6 ms1.6 ms

Commits

Click on a commit to change the comparison range

Base

main

353b153

-0.01%

feat(linter): add `vue/no-export-in-script-setup` rule (#14307) the original rule iterates over all the nodes, and will detect empty `ExportNamedDeclaration` (`export {}`). I tried to use the `ModuleRecord` to simplify the implementation, but it results into different spans / results. https://github.com/vuejs/eslint-plugin-vue/blob/553abe61c4d7a8964fb154069ea6a82d14b2b3b6/tests/lib/rules/no-export-in-script-setup.js#L220-L226 https://eslint.vuejs.org/rules/no-export-in-script-setup.html related #11440

f5c6acc

3 days ago

by Sysix

Home Terms Privacy Docs