09-24-refactor_linter_add_compositefix_merge_fixes_fallible_method - Branch - oxc-project/oxc

refactor(linter): add `CompositeFix::merge_fixes_fallible` method

#14093Merged

Comparing

09-24-refactor_linter_add_compositefix_merge_fixes_fallible_method

(

f91db73

) with

main

(

8b7c784

)

Untouched: 37

No successful run was found on main ( f91db73) during the generation of this report, so 8b7c784 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Passed

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

11.7 µs11.6 µs

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

34.1 ms34 ms

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

4.3 ms4.3 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20 µs20 µs

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms1.7 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.6 ms1.6 ms

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4 ms4 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

27.7 ms27.7 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

711.4 µs711.1 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

133.9 µs133.9 µs

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

210.4 ms210.4 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

733 ms732.9 ms

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

23.6 ms23.6 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

56.4 ms56.4 ms

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

733.8 µs733.8 µs

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

88.6 ms88.5 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

104.6 ms104.6 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

870.2 µs870.3 µs

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.3 ms5.3 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

26.6 ms26.6 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.3 ms1.3 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.3 ms3.3 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

118.8 µs118.8 µs

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

356.7 µs356.8 µs

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

32.8 ms32.8 ms

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

2.8 ms2.8 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

83.7 µs83.7 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.5 ms2.5 ms

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

11.8 ms11.8 ms

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.8 ms1.8 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

259.3 µs259.6 µs

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.9 ms3.9 ms

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.7 ms1.7 ms

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

31.5 ms31.5 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

75.1 µs75.3 µs

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

-1%

579.1 µs584.1 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

-1%

26.4 ms26.7 ms

Commits

Click on a commit to change the comparison range

Base

main

8b7c784

-0.06%

refactor(linter): add `CompositeFix::merge_fixes_fallible` method (#14093) Add a method `CompositeFix::merge_fixes_fallible` which returns `Result::Err` in case of overlapping fixes or other illegal states, instead of panicking in debug mode. `CompositeFix::merge_fixes` does the same as it did before, but uses `merge_fixes_fallible` internally. Use an error type `MergeFixesError` instead of `String` to avoid adding string formatting overhead when the primary use case in release mode is to ignore the errors anyway. `merge_fixes_fallible` will be used in JS plugins where we don't want to panic on these illegal states, but output a diagnostic instead.

f91db73

2 months ago

by overlookmotel

Home Terms Privacy Docs