09-24-fix_linter_no-useless-escape_do_not_crash_on_c_ - Branch - oxc-project/oxc

fix(linter): `no-useless-escape`: do not crash on backslash character

#6048Merged

Comparing

09-24-fix_linter_no-useless-escape_do_not_crash_on_c_

(

c047d42

) with

main

(

58d333a

)

Untouched: 29

Benchmarks

Passed

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+2%

36.4 ms35.8 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

99.6 µs99.2 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

23.6 µs23.6 µs

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

19.6 ms19.6 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

7.7 ms7.7 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

51.5 ms51.5 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

31.4 ms31.4 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.5 ms17.5 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

118.8 ms118.8 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.4 ms5.4 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24.7 ms24.7 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

20.7 ms20.7 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

894.9 ms894.9 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.5 ms3.5 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

72.8 ms72.8 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

530.9 ms530.9 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

107.4 ms107.4 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

53.4 ms53.4 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

13 ms13 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

20.8 ms20.8 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

61.6 ms61.6 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

21.8 ms21.8 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

160.2 µs160.2 µs

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

596.3 ms596.3 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.3 s1.3 s

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

5.2 ms5.2 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

72.5 ms72.5 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

79.3 µs79.4 µs

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.4 s2.4 s

Commits

Click on a commit to change the comparison range

Base

main

58d333a

+0.07%

fix(linter): `no-useless-escape`: do not crash on backslash character (#6048) Fixes https://github.com/oxc-project/oxc/issues/6046 Unlike other escape sequences such as `/\w/`, this is not actually parsed as a single character: `/\c/` so we incorrectly try to get the character before the backslash, which doesn't exist.

c047d42

1 year ago

by camchenry

Home Terms Privacy Docs