09-19-fix_formatter_missing_semicolon_for_declare_function - Branch - oxc-project/oxc

oxc-project

oxc

Instrumentation

Wall Time

Blog Docs Changelog

fix(formatter): missing semicolon for `declare` function

#13928Merged

Comparing

09-19-fix_formatter_missing_semicolon_for_declare_function

(

3ce0775

) with

09-19-feat_formatter_implement_formatting_for_tstypeparameter_and_tstypeparameterinstantiation

(

06a1df6

)

Untouched: 37

Benchmarks

Passed

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[cal.com.tsx]

+1%

31.6 ms31.4 ms

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[RadixUIAdoptionSection.jsx]

+1%

580.3 µs577.3 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[cal.com.tsx]

26.4 ms26.3 ms

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[react.development.js]

11.7 ms11.7 ms

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[binder.ts]

4.3 ms4.3 ms

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[binder.ts]

4 ms4 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[binder.ts]

1.7 ms1.7 ms

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[react.development.js]

1.9 ms1.9 ms

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[binder.ts]

23.5 ms23.5 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[react.development.js]

2.4 ms2.4 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations::isolated-declarations[vue-id.ts]

56.4 ms56.3 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[cal.com.tsx]

26.6 ms26.6 ms

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler::mangler[RadixUIAdoptionSection.jsx]

11.5 µs11.5 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[RadixUIAdoptionSection.jsx]

20.1 µs20.1 µs

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree::estree[checker.ts]

104.6 ms104.6 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[cal.com.tsx]

5.3 ms5.3 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[RadixUIAdoptionSection.jsx]

1.7 ms1.7 ms

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler::mangler[binder.ts]

733.4 µs733.4 µs

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[cal.com.tsx]

34.3 ms34.3 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[react.development.js]

1.3 ms1.3 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[binder.ts]

870.1 µs870.2 µs

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[binder.ts]

97.8 ms97.8 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[cal.com.tsx]

813.4 ms813.5 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[react.development.js]

710.5 µs710.6 µs

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[cal.com.tsx]

209.9 ms210 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[binder.ts]

3.3 ms3.3 ms

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[react.development.js]

35.3 ms35.4 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[RadixUIAdoptionSection.jsx]

83.5 µs83.6 µs

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[react.development.js]

356.6 µs356.9 µs

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[cal.com.tsx]

27.7 ms27.7 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler::mangler[react.development.js]

259.1 µs259.3 µs

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler::mangler[cal.com.tsx]

2.8 ms2.8 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[RadixUIAdoptionSection.jsx]

134.6 µs134.7 µs

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[RadixUIAdoptionSection.jsx]

119.8 µs120 µs

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[react.development.js]

1.7 ms1.7 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[binder.ts]

3.9 ms4 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[RadixUIAdoptionSection.jsx]

75.3 µs75.6 µs

Commits

Click on a commit to change the comparison range

Base

09-19-feat_formatter_implement_formatting_for_tstypeparameter_and_tstypeparameterinstantiation

06a1df6

fix(formatter): missing semicolon for `declare` function (#13928) ```ts // normal function function a() {} // declare function declare function a(): void; ``` `declare function` without a function body, so it behaves like a `declare var a: void`, thus the semicolon is needed

3ce0775

8 days ago

by Dunqing

Home Terms Privacy Docs