09-09-refactor_allocator_pool_single_allocatorpool_implementation - Branch - oxc-project/oxc

refactor(allocator/pool): single `AllocatorPool` implementation

#13622Merged

Comparing

09-09-refactor_allocator_pool_single_allocatorpool_implementation

(

a306c6f

) with

main

(

f9bff64

)

Untouched: 37

No successful run was found on main ( 99dd1a7) during the generation of this report, so f9bff64 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Passed

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

26.7 ms26.4 ms

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

+1%

574.2 µs571.3 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

133.8 µs133.4 µs

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

22.6 ms22.5 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

85.2 µs85 µs

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.9 ms1.9 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms1.7 ms

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

2.8 ms2.8 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

712.7 µs712.4 µs

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

733.7 µs733.5 µs

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.3 ms3.3 ms

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

50.3 ms50.3 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

28.2 ms28.2 ms

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

141.9 ms141.9 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

26.9 ms26.9 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

104.5 ms104.5 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.3 ms5.3 ms

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

11.5 ms11.5 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.4 ms2.4 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.3 ms1.3 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

870 µs870.3 µs

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

356.8 µs356.9 µs

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

4.3 ms4.3 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

56.3 ms56.4 ms

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

206.9 ms207 ms

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4 ms4 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

259.2 µs259.4 µs

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

120.3 µs120.4 µs

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.7 ms1.7 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.8 ms3.8 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.4 ms2.4 ms

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

34.4 ms34.4 ms

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

11.5 µs11.5 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20 µs20.1 µs

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

31 ms31.1 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

77.1 µs77.7 µs

Commits

Click on a commit to change the comparison range

Base

main

f9bff64

+0.01%

refactor(allocator/pool): single `AllocatorPool` implementation (#13622) Previously we had 2 different versions of `AllocatorPool`. Which version is used was controlled purely by the `fixed_size` / `disable_fixed_size` Cargo features. Combine the 2 versions into a single `AllocatorPool` struct which can represent *either* a standard or a fixed-size allocator pool at runtime. 1. `AllocatorPool::new` creates a pool which uses standard allocators. 2. `AllocatorPool::new_fixed_size` creates a pool which uses fixed-size allocators. `AllocatorPool::new_fixed_size` is feature-gated behind `fixed_size` Cargo feature. Currently `AllocatorPool::new` still creates a fixed-size pool if `fixed_size` feature is enabled. That's just to avoid a change which would break the linter. Next PR will update the linter to conditionally use `AllocatorPool::new_fixed_size`, and then this workaround can be removed.

a306c6f

2 months ago

by overlookmotel

Home Terms Privacy Docs