08-27-fix_semantic_flag_super_in_function_inside_objectexpression_ - Branch - oxc-project/oxc

fix(semantic): flag `super` in function inside `ObjectExpression`

#13325Merged

Comparing

08-27-fix_semantic_flag_super_in_function_inside_objectexpression_

(

fd3233c

) with

main

(

84a584c

)

+13%

Improvements: 1

Untouched: 37

No successful run was found on main ( fd3233c) during the generation of this report, so 84a584c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Improved

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

+13%

3.8 ms3.4 ms

Passed

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

+1%

14.9 µs14.7 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

77.3 µs76.6 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20 µs20 µs

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

35.7 ms35.6 ms

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

11.5 ms11.5 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

291.5 µs291.1 µs

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

719 µs718.1 µs

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

30.3 ms30.3 ms

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4.2 ms4.2 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms1.7 ms

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.9 ms1.9 ms

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.7 ms1.7 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.3 ms1.3 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

125.2 µs125.2 µs

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.3 ms3.3 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.6 ms2.6 ms

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

52.6 ms52.6 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

26.8 ms26.8 ms

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

148.1 ms148.1 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.3 ms5.3 ms

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

22.6 ms22.6 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

104.5 ms104.5 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.3 ms2.3 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

870.2 µs870.4 µs

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

4.3 ms4.3 ms

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

206.9 ms207 ms

minifier[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

59.1 µs59.2 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

26.8 ms26.8 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

57.3 ms57.3 ms

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

356.8 µs357 µs

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

826.8 µs827.4 µs

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

27.9 ms27.9 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.7 ms3.8 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

84 µs84.1 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

133 µs133.6 µs

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

-1%

568.9 µs576.3 µs

Commits

Click on a commit to change the comparison range

Base

main

84a584c

+13.33%

fix(semantic): flag `super` in function inside `ObjectExpression` (#13325) Fix #13323. Make semantic raise errors for the following illegal `super` uses: ```js o = { foo: function() { super.foo; }, bar() { return function() { super.bar; }; }, [ function() { super.qux; } ]() {}, get [ function() { super.bing; } ]() {}, set [ function() { super.bong; } ](v) {}, }; ```

fd3233c

3 months ago

by overlookmotel

Home Terms Privacy Docs