08-19-fix_linter_parse_ignorepatterns_with_gitignore_syntax - Branch - oxc-project/oxc

oxc-project

oxc

Instrumentation

Wall Time

Blog Docs Changelog

fix(linter): parse `ignorePatterns` with gitignore syntax

#13221Merged

Comparing

08-19-fix_linter_parse_ignorepatterns_with_gitignore_syntax

(

648e939

) with

main

(

2761300

)

Untouched: 34

No successful run was found on main ( 648e939) during the generation of this report, so 2761300 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Passed

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[cal.com.tsx]

+1%

26.8 ms26.4 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[RadixUIAdoptionSection.jsx]

119.7 µs119.3 µs

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[cal.com.tsx]

33.9 ms33.8 ms

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[cal.com.tsx]

29.9 ms29.8 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[RadixUIAdoptionSection.jsx]

20 µs20 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[react.development.js]

2.1 ms2.1 ms

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[binder.ts]

21.6 ms21.6 ms

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[binder.ts]

4.1 ms4.1 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[cal.com.tsx]

1.2 s1.2 s

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[binder.ts]

3.3 ms3.3 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[react.development.js]

1.3 ms1.3 ms

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[react.development.js]

357 µs356.9 µs

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[react.development.js]

52.6 ms52.6 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree::estree[checker.ts]

104.5 ms104.5 ms

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[react.development.js]

1.9 ms1.9 ms

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[binder.ts]

147.6 ms147.6 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[binder.ts]

1.7 ms1.7 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[cal.com.tsx]

26.7 ms26.7 ms

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[cal.com.tsx]

179.3 ms179.3 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[cal.com.tsx]

5.3 ms5.3 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations::isolated-declarations[vue-id.ts]

57.3 ms57.3 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[RadixUIAdoptionSection.jsx]

2.5 ms2.5 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[binder.ts]

870.2 µs870.5 µs

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[binder.ts]

4.3 ms4.3 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[cal.com.tsx]

27.9 ms27.9 ms

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[react.development.js]

1.7 ms1.7 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[react.development.js]

717.4 µs717.8 µs

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[react.development.js]

11.1 ms11.1 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[binder.ts]

3.6 ms3.6 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[RadixUIAdoptionSection.jsx]

83.6 µs83.8 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[RadixUIAdoptionSection.jsx]

133.1 µs133.5 µs

minifier[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[RadixUIAdoptionSection.jsx]

58.5 µs58.8 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[RadixUIAdoptionSection.jsx]

-1%

76.6 µs77 µs

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[RadixUIAdoptionSection.jsx]

-1%

341.8 µs344 µs

Commits

Click on a commit to change the comparison range

Base

main

2761300

-0.01%

fix(linter): parse `ignorePatterns` with gitignore syntax (#13221) closes #13204 Why I need now a `GitignoreBuilder` instead of `OverrideBuilder` like before #12210. Because `Gitignore::matched_path_or_any_parents` only allows paths inside his root, I needed to "trick" a bit. Or else the test with `--config another/directory/config.json` would fail. Now, the base `ignorePatterns` will always be at the current working directory.

648e939

1 month ago

by Sysix

Home Terms Privacy Docs