08-15-feat_minifier_rewrite_arguments_copy_loops_to_spread_syntax - Branch - oxc-project/oxc

feat(minifier): rewrite `arguments` copy loops to spread syntax

#13114Merged

Comparing

08-15-feat_minifier_rewrite_arguments_copy_loops_to_spread_syntax

(

3d0d31a

) with

main

(

c661bac

)

Untouched: 34

No successful run was found on main ( 3d0d31a) during the generation of this report, so c661bac was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Passed

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

26.4 ms26.2 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

77.1 µs76.8 µs

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

11.1 ms11.1 ms

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

30 ms29.9 ms

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

21.6 ms21.5 ms

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4.2 ms4.2 ms

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

356.7 µs356.5 µs

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

34.1 ms34.1 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

83.5 µs83.5 µs

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.5 ms2.5 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

26.7 ms26.7 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

57.3 ms57.3 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

179.4 ms179.4 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

27.9 ms27.9 ms

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

146.6 ms146.6 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

19.8 µs19.8 µs

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

52.3 ms52.3 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.3 ms3.3 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.3 ms5.3 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

104.5 ms104.5 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.3 ms1.3 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms1.7 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

869.9 µs870 µs

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.9 ms1.9 ms

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

4.3 ms4.3 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

717.1 µs717.4 µs

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

342.9 µs343 µs

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.7 ms1.7 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.1 ms2.1 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.6 ms3.6 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

123.2 µs123.4 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

133.1 µs133.4 µs

minifier[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

58.1 µs58.2 µs

Commits

Click on a commit to change the comparison range

Base

main

c661bac

+0.03%

feat(minifier): rewrite `arguments` copy loops to spread syntax (#13114) Reverse-transpile rest argument code generated by TypeScript and babel. Example input: ```js for (var e = arguments.length, r = Array(e), a = 0; a < e; a++) r[a] = arguments[a]; ``` output: ```js var r = [...arguments]; ``` It's a quite specific transform though.

3d0d31a

3 months ago

by sapphi-red

Home Terms Privacy Docs