08-12-fix_allocator_remove_vec_bump_method - Branch - oxc-project/oxc

fix(allocator): remove `Vec::bump` method

#13039Merged

Comparing

08-12-fix_allocator_remove_vec_bump_method

(

af3b98e

) with

main

(

9ac418d

)

Untouched: 34

No successful run was found on 08-12-fix_allocator_remove_clone_impl_from_vec_ ( 9ac418d) during the generation of this report, so 98eac10 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Passed

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

+2%

30.7 ms30.1 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.7 ms3.7 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

19.9 µs19.9 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

77 µs76.9 µs

minifier[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

58.6 µs58.5 µs

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

11.1 ms11.1 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.2 ms2.1 ms

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

33.9 ms33.9 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

83.8 µs83.8 µs

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

356.9 µs356.7 µs

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

57.3 ms57.3 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

870.4 µs870.1 µs

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4.1 ms4.1 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

26.7 ms26.7 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.3 ms1.3 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.5 ms2.5 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

27.9 ms27.9 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.3 ms3.3 ms

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

4.3 ms4.3 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.3 ms5.3 ms

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

21.5 ms21.5 ms

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

179.4 ms179.4 ms

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

52.3 ms52.3 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

104.5 ms104.5 ms

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

343.4 µs343.4 µs

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

146.6 ms146.6 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms1.7 ms

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.9 ms1.9 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

718.2 µs718.8 µs

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.7 ms1.7 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

119.3 µs119.5 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

133.1 µs133.5 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

-1%

26.3 ms26.4 ms

Commits

Click on a commit to change the comparison range

Base

08-12-fix_allocator_remove_clone_impl_from_vec_

9ac418d

+0.05%

fix(allocator): remove `Vec::bump` method (#13039) `Vec::bump` method is unsound. * `Vec` is `Sync`, which means that you can have 2 `&Vec` references on different threads. * `Vec::bump` allows converting a `&Vec` into a `&Bump`, which means you can obtain 2 `&Bump`s on different threads. * `Bump` uses interior mutability, so you only need a `&Bump` (not `&mut Bump`) to allocate into that arena. * `Bump` is not thread-safe (hence it's not `Sync`) and allocating into the arena from 2 different threads simultaneously is UB. We don't use this method anyway, and I can't see any prospect of us doing so in future, so remove it. This will enable us to keep `Vec` being `Sync` without unsoundness.

af3b98e

3 months ago

by overlookmotel

Home Terms Privacy Docs