08-10-perf_minifier_avoid_repeated_atom_creation_in_injectglobalvariables_ - Branch - oxc-project/oxc

perf(minifier): avoid repeated `Atom` creation in `InjectGlobalVariables`

#4802Merged

Comparing

08-10-perf_minifier_avoid_repeated_atom_creation_in_injectglobalvariables_

(

35f2742

) with

main

(

62f759c

)

Untouched: 29

Benchmarks

Passed

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

101.5 µs100.4 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

224.1 µs223 µs

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

126.9 ms126.8 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

77 µs77 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

63.1 ms63 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

37.8 ms37.8 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

139.1 ms139.1 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

352.5 ms352.4 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

4.9 ms4.9 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

635.4 ms635.3 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

61.5 ms61.5 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

19.9 ms19.9 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.7 ms3.7 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

104.2 ms104.2 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.1 ms17.1 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24.2 ms24.2 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.6 ms52.6 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.2 µs22.2 µs

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

19.9 ms19.9 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

379.7 ms379.7 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

245.4 ms245.4 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

76.1 ms76.1 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

20.8 ms20.8 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

72.7 ms72.8 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.4 s1.4 s

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

-1%

777.1 ms788.4 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-2%

46.4 ms47.3 ms

Commits

Click on a commit to change the comparison range

Base

main

62f759c

-0.07%

perf(minifier): avoid repeated `Atom` creation in `InjectGlobalVariables` (#4802) Re-use `Atom`s in `InjectGlobalVariables` minifier plugin. Instead of allocating a new `Atom` on every replacement, create `Atom` lazily when making first replacement, and cache it. As discussed in: https://github.com/oxc-project/oxc/pull/4759#discussion_r1711669464

35f2742

1 year ago

by overlookmotel

Home Terms Privacy Docs