08-09-refactor_ast_codegen_use_doc_comments_instead_of_insert_ - Branch - oxc-project/oxc

refactor(ast_codegen): use doc comments instead of `insert!`

#4777Merged

Comparing

08-09-refactor_ast_codegen_use_doc_comments_instead_of_insert_

(

f418f62

) with

main

(

b22ed45

)

Untouched: 29

Benchmarks

Passed

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

47.3 ms46.8 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.4 s1.4 s

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

20.8 ms20.8 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

223.1 µs222.8 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.3 µs22.2 µs

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

19.9 ms19.9 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

126.9 ms126.9 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

37.8 ms37.8 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.4 ms52.4 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

4.9 ms4.9 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

380.3 ms380.3 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

352.6 ms352.6 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

139 ms139 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

245.2 ms245.2 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

20 ms20 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24.2 ms24.2 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

104.3 ms104.3 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

635.6 ms635.6 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

76.1 ms76.1 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.1 ms17.1 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

63 ms63 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

72.8 ms72.9 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.7 ms3.7 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

77.2 µs77.2 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

100 µs100.2 µs

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

61.5 ms61.6 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

783.1 ms785.6 ms

Commits

Click on a commit to change the comparison range

Base

main

b22ed45

+0.03%

refactor(ast_codegen): use doc comments instead of `insert!` (#4777) Avoid the `insert!` macro in AST codegen. Use doc comments starting with special symbol `@` instead. * Before: `insert!("// plain comment");` * After: `///@ plain comment` * Or: `//!@ plain comment` Either `///@` or `//!@` is converted to plain `//` in output. `//!@` is legal in top-of-file position, which allows us to inline `#![allow(...)]` attributes, which in my opinion makes the generators a bit easier to read.

f418f62

1 year ago

by overlookmotel

Home Terms Privacy Docs