08-09-refactor_ast_codegen_trim_r_from_start_of_field_names - Branch - oxc-project/oxc

refactor(ast_codegen): trim `r#` from start of field names

#4785Merged

Comparing

08-09-refactor_ast_codegen_trim_r_from_start_of_field_names

(

ec82a79

) with

main

(

c79ca40

)

Untouched: 29

Benchmarks

Passed

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+1%

1.4 s1.4 s

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+1%

785.2 ms780.7 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

223.6 µs222.4 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.3 µs22.3 µs

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

77.3 µs77.2 µs

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

72.9 ms72.9 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

46.5 ms46.5 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

61.5 ms61.5 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

139 ms139 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.1 ms17.1 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

19.9 ms19.9 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

245.2 ms245.2 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

352.6 ms352.6 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

20 ms20 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.4 ms52.4 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

104.3 ms104.3 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

37.8 ms37.8 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

380.3 ms380.3 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

126.9 ms126.9 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24.2 ms24.2 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

635.6 ms635.7 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

4.9 ms4.9 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

76.1 ms76.1 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

63 ms63 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.7 ms3.7 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

20.7 ms20.8 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

100.6 µs100.7 µs

Commits

Click on a commit to change the comparison range

Base

main

c79ca40

+0.06%

refactor(ast_codegen): trim `r#` from start of field names (#4785) Some struct fields are reserved names e.g. `type`. They are written in source as `r#type`. Trim off the `r#` prefix in `FieldDef::name` and add it back when generating output. Main motivation is to have the unescaped field names in JSON schema.

ec82a79

1 year ago

by overlookmotel

Home Terms Privacy Docs