08-09-refactor_ast_codegen_remove_unnecessary_imports_from_generated_files - Branch - oxc-project/oxc

refactor(ast_codegen): remove unnecessary imports from generated files

#4774Merged

Comparing

08-09-refactor_ast_codegen_remove_unnecessary_imports_from_generated_files

(

dbb5f4c

) with

main

(

daa0b2e

)

Untouched: 29

Benchmarks

Passed

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

222.9 µs222.6 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.3 µs22.3 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

63 ms63 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

47.3 ms47.3 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

4.9 ms4.9 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

61.5 ms61.5 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

139 ms139 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

19.9 ms19.9 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

245.2 ms245.2 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

635.6 ms635.6 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.4 ms52.4 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

20 ms20 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24.2 ms24.2 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

72.8 ms72.8 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

104.3 ms104.3 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

380.3 ms380.3 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

352.6 ms352.6 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

76.1 ms76.1 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

126.8 ms126.9 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.1 ms17.1 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

77.2 µs77.3 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.7 ms3.7 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

37.8 ms37.8 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.4 s1.4 s

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

20.8 ms20.8 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

100.1 µs100.4 µs

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

776.8 ms779.7 ms

Commits

Click on a commit to change the comparison range

Base

main

daa0b2e

-0.02%

refactor(ast_codegen): remove unnecessary imports from generated files (#4774) #4773 makes types like `Span` importable from `oxc_ast::ast`, so remove the imports from other crates in generated code. I'm not sure why clippy's `wildcard_imports` rule was not being triggered for `use crate::ast::*;`, but add `#[allow(clippy::wildcard_imports)]` on these statements just to make sure.

dbb5f4c

1 year ago

by overlookmotel

Home Terms Privacy Docs