08-02-feat_ast_getspanmut_trait - Branch - oxc-project/oxc

feat(ast): `GetSpanMut` trait

#4609Merged

Comparing

08-02-feat_ast_getspanmut_trait

(

54047e0

) with

main

(

f259df0

)

Untouched: 32

Benchmarks

Passed

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+1%

781.7 ms773.7 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

46.9 ms46.5 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

222 µs220.9 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

100.5 µs100.1 µs

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

76.4 µs76.3 µs

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

232.1 µs231.9 µs

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

37.6 ms37.6 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

126.3 ms126.3 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

76.5 ms76.5 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24 ms24 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

75.9 ms75.9 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.4 ms52.4 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

379.2 ms379.1 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

103.5 ms103.5 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

62.4 ms62.4 ms

prepass[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

17.5 ms17.5 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

19.9 ms19.9 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

32 ms32 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17 ms17 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

138.7 ms138.7 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

4.9 ms4.9 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

244.2 ms244.2 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

19.9 ms19.9 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

516.6 ms516.7 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

284.1 ms284.3 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

71.1 ms71.2 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

20.7 ms20.7 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.2 ms3.2 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.3 µs22.3 µs

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

-1%

1.4 s1.4 s

Commits

Click on a commit to change the comparison range

Base

main

f259df0

+0.05%

feat(ast): `GetSpanMut` trait (#4609) Closes #4606. Introduce `GetSpanMut` trait and implement it on all AST node types. This has to be a separate trait, rather than adding `span_mut` method to `GetSpan` because `AstKind` implements `GetSpan`, and it only has an immutable `&` ref to AST node it contains.

54047e0

1 year ago

by overlookmotel

Home Terms Privacy Docs