07-31-perf_sourcemap_elide_bounds_checks_in_vlq_encoding - Branch - oxc-project/oxc

perf(sourcemap): elide bounds checks in VLQ encoding

#4583Merged

Comparing

07-31-perf_sourcemap_elide_bounds_checks_in_vlq_encoding

(

d00014e

) with

main

(

e116ae0

)

Untouched: 32

Benchmarks

Passed

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

46.4 ms46.3 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.5 µs22.4 µs

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

74.7 ms74.6 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

20.7 ms20.7 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

62.4 ms62.4 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

138.7 ms138.7 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

243.9 ms243.8 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

32.1 ms32.1 ms

prepass[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

17.6 ms17.6 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

377.5 ms377.5 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

19.9 ms19.9 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

37.6 ms37.6 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

103.1 ms103.1 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17 ms17 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

19.9 ms19.9 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.2 ms52.2 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

4.9 ms4.9 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

283.8 ms283.8 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

23.9 ms23.9 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

76.1 µs76.1 µs

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

126.4 ms126.4 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

76 ms76 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

99.6 µs99.7 µs

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

515.7 ms515.8 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.2 ms3.2 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.4 s1.4 s

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

221.3 µs221.5 µs

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

786.8 ms788.3 ms

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

232.4 µs233.2 µs

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

-1%

76.5 ms77.2 ms

Commits

Click on a commit to change the comparison range

Base

main

e116ae0

-0.04%

perf(sourcemap): elide bounds checks in VLQ encoding (#4583) In `oxc_sourcemap`'s VLQ encoding, avoid bounds checks when pushing bytes to the encoded string in the hot loop. Those bounds checks are quite expensive as they involve a function call to `alloc::raw_vec::RawVec::grow_one`, and that happens on every single pushed byte. https://godbolt.org/z/44G8jjss3 Not much difference on benchmarks, as VLQ encoding is only a small part of source map generation, but a local benchmark of just VLQ encoding shows this increases performance by 11%.

d00014e

1 year ago

by overlookmotel

Home Terms Privacy Docs