07-30-perf_parser_use_-_not_saturating_sub_ - Branch - oxc-project/oxc

perf(parser): use `-` not `saturating_sub`

#4561Merged

Comparing

07-30-perf_parser_use_-_not_saturating_sub_

(

ab8509e

) with

main

(

7585e16

)

Untouched: 32

Benchmarks

Passed

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+2%

47.3 ms46.4 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

100.7 µs100.1 µs

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

20.7 ms20.7 ms

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

233.1 µs232.5 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

222 µs221.6 µs

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

787.9 ms786.6 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

74.5 ms74.4 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

37.6 ms37.6 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

19.9 ms19.9 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.3 ms52.3 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

4.9 ms4.9 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

62.4 ms62.4 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

23.9 ms23.9 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17 ms17 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

75 ms75 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

138.6 ms138.6 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

243.9 ms243.9 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

32.1 ms32.1 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

103.3 ms103.3 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

18.3 ms18.3 ms

prepass[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

17.6 ms17.6 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

378.4 ms378.4 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

75.9 ms75.9 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

515.8 ms515.9 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

126.4 ms126.5 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.2 ms3.2 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

283.7 ms283.8 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

76.1 µs76.3 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

-1%

22.3 µs22.5 µs

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

-1%

1.4 s1.4 s

Commits

Click on a commit to change the comparison range

Base

main

7585e16

+0.06%

perf(parser): use `-` not `saturating_sub` (#4561) Follow-on after #4304. Avoid using `saturating_sub` when plain `-` will do. `-` is cheaper - it's a single assembly instruction, whereas `saturating_sub` is usually 3 instructions. https://godbolt.org/z/fo8Tcx6bK

ab8509e

1 year ago

by overlookmotel

Home Terms Privacy Docs